mbox series

[v3,0/5] net: macb: cover letter

Message ID 1561106037-6859-1-git-send-email-pthombar@cadence.com
Headers show
Series net: macb: cover letter | expand

Message

Parshuram Raju Thombare June 21, 2019, 8:33 a.m. UTC 
Hello !

This is third version of patch set containing following patches
for Cadence ethernet controller driver.

1. 0001-net-macb-add-phylink-support.patch
   Replace phylib API's with phylink API's.
2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch
   This patch add support for SGMII mode.
3. 0004-net-macb-add-support-for-c45-PHY.patch
   This patch is to support C45 PHY.
4. 0005-net-macb-add-support-for-high-speed-interface
   This patch add support for 10G USXGMII PCS in fixed mode.
5. 0006-net-macb-parameter-added-to-cadence-ethernet-controller-DT-binding
   New parameter added to Cadence ethernet controller DT binding
   for USXGMII interface.

Changes in v2:
1. Dropped patch configuring TI PHY DP83867 from
   Cadence PCI wrapper driver.
2. Removed code registering emulated PHY for fixed mode. 
3. Code reformatting as per Andrew's and Florian's suggestions.

Changes in v3:
Based on Russell's suggestions
1. Configure MAC in mac_config only for non in-band modes
2. Handle dynamic phy_mode changes in mac_config
3. Move MAC configurations to mac_config
4. Removed seemingly redundant check for phylink handle
5. Removed code from mac_an_restart and mac_link_state
   now just return -EOPNOTSUPP

Regards,
Parshuram Thombare

Parshuram Thombare (5):
  net: macb: add phylink support
  net: macb: add support for sgmii MAC-PHY interface
  net: macb: add support for c45 PHY
  net: macb: add support for high speed interface
  net: macb: parameter added to cadence ethernet controller DT binding

 .../devicetree/bindings/net/macb.txt          |   3 +
 drivers/net/ethernet/cadence/Kconfig          |   2 +-
 drivers/net/ethernet/cadence/macb.h           | 113 +++-
 drivers/net/ethernet/cadence/macb_main.c      | 619 +++++++++++++-----
 4 files changed, 554 insertions(+), 183 deletions(-)

Comments

Andrew Lunn June 21, 2019, 1:16 p.m. UTC | #1 
On Fri, Jun 21, 2019 at 09:33:57AM +0100, Parshuram Thombare wrote:
> Hello !
> 
> 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch
>    This patch add support for SGMII mode.

Hi Parshuram

What PHYs are using to test this? You mention TI PHY DP83867, but that
seems to be a plain old 10/100/1000 RGMII PHY.

      Thanks
	Andrew
Parshuram Raju Thombare June 22, 2019, 3:18 a.m. UTC | #2 
Hi Andrew,

>On Fri, Jun 21, 2019 at 09:33:57AM +0100, Parshuram Thombare wrote:
>> Hello !
>>
>> 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch
>>    This patch add support for SGMII mode.
>
>Hi Parshuram
>
>What PHYs are using to test this? You mention TI PHY DP83867, but that seems to
>be a plain old 10/100/1000 RGMII PHY.
It is DP83867ISRGZ on VCU118 board. This PHY supports SGMII but driver dp83867 
doesn't seems to support it, that was the reason previous patch set has patch
trying to configure PHY in SGMII mode from PCI wrapper driver.

Regards,
Parshuram Thombare
Russell King (Oracle) June 22, 2019, 8:41 a.m. UTC | #3 
On Sat, Jun 22, 2019 at 03:18:42AM +0000, Parshuram Raju Thombare wrote:
> Hi Andrew,
> 
> >On Fri, Jun 21, 2019 at 09:33:57AM +0100, Parshuram Thombare wrote:
> >> Hello !
> >>
> >> 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch
> >>    This patch add support for SGMII mode.
> >
> >Hi Parshuram
> >
> >What PHYs are using to test this? You mention TI PHY DP83867, but that seems to
> >be a plain old 10/100/1000 RGMII PHY.
> It is DP83867ISRGZ on VCU118 board. This PHY supports SGMII but driver
> dp83867 doesn't seems to support it, that was the reason previous patch
> set has patch trying to configure PHY in SGMII mode from PCI wrapper driver.

There are several versions of the dp83867 phy supporting various
interface modes.  It seems the driver has been written for the
DP83867IR and DP83867CR family, presumably TI data sheet SNLS484E.
The DP83867E/IS/CS is covered by a separate data sheet, SNLS504B.

Please note that this PHY does not support 2.5G operation in any
mode.
Andrew Lunn June 22, 2019, 2:54 p.m. UTC | #4 
On Sat, Jun 22, 2019 at 03:18:42AM +0000, Parshuram Raju Thombare wrote:
> Hi Andrew,
> 
> >On Fri, Jun 21, 2019 at 09:33:57AM +0100, Parshuram Thombare wrote:
> >> Hello !
> >>
> >> 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch
> >>    This patch add support for SGMII mode.
> >
> >Hi Parshuram
> >
> >What PHYs are using to test this? You mention TI PHY DP83867, but that seems to
> >be a plain old 10/100/1000 RGMII PHY.
> It is DP83867ISRGZ on VCU118 board.

Thanks.

As Russell says, this is still a 10/100/1000 PHY. What are you using
for the higher speeds?

    Thanks
	Andrew