| Message ID | 1560642579-29803-1-git-send-email-pthombar@cadence.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: macb patch set cover letter | expand |
On Sun, Jun 16, 2019 at 12:49:39AM +0100, Parshuram Thombare wrote: > New parameters added to Cadence ethernet controller DT binding > for USXGMII interface. > > Signed-off-by: Parshuram Thombare <pthombar@cadence.com> > --- > Documentation/devicetree/bindings/net/macb.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > index 9c5e94482b5f..cd79ec9dddfb 100644 > --- a/Documentation/devicetree/bindings/net/macb.txt > +++ b/Documentation/devicetree/bindings/net/macb.txt > @@ -25,6 +25,10 @@ Required properties: > Optional elements: 'rx_clk' applies to cdns,zynqmp-gem > Optional elements: 'tsu_clk' > - clocks: Phandles to input clocks. > +- serdes-rate External serdes rate.Mandatory for USXGMII mode. > + 0 - 5G > + 1 - 10G Please use the values 5 and 10, not 0 and 1. This also needs a vendor prefix. Andrew
>On Sun, Jun 16, 2019 at 12:49:39AM +0100, Parshuram Thombare wrote: >> New parameters added to Cadence ethernet controller DT binding for >> USXGMII interface. >> >> Signed-off-by: Parshuram Thombare <pthombar@cadence.com> >> --- >> Documentation/devicetree/bindings/net/macb.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/macb.txt >> b/Documentation/devicetree/bindings/net/macb.txt >> index 9c5e94482b5f..cd79ec9dddfb 100644 >> --- a/Documentation/devicetree/bindings/net/macb.txt >> +++ b/Documentation/devicetree/bindings/net/macb.txt >> @@ -25,6 +25,10 @@ Required properties: >> Optional elements: 'rx_clk' applies to cdns,zynqmp-gem >> Optional elements: 'tsu_clk' >> - clocks: Phandles to input clocks. >> +- serdes-rate External serdes rate.Mandatory for USXGMII mode. >> + 0 - 5G >> + 1 - 10G > Ok >Please use the values 5 and 10, not 0 and 1. This also needs a vendor prefix. > > Andrew Regards, Parshuram Thombare
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 9c5e94482b5f..cd79ec9dddfb 100644 --- a/Documentation/devicetree/bindings/net/macb.txt +++ b/Documentation/devicetree/bindings/net/macb.txt @@ -25,6 +25,10 @@ Required properties: Optional elements: 'rx_clk' applies to cdns,zynqmp-gem Optional elements: 'tsu_clk' - clocks: Phandles to input clocks. +- serdes-rate External serdes rate.Mandatory for USXGMII mode. + 0 - 5G + 1 - 10G +- fixed-speed Speed for fixed mode UXSGMII interface based link The MAC address will be determined using the optional properties defined in ethernet.txt.
New parameters added to Cadence ethernet controller DT binding for USXGMII interface. Signed-off-by: Parshuram Thombare <pthombar@cadence.com> --- Documentation/devicetree/bindings/net/macb.txt | 4 ++++ 1 file changed, 4 insertions(+)