| Message ID | 20190617083117.1690-1-sr@denx.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2,v4] dt-bindings: i2c: i2c-mt7621: Add bindings for MediaTek MT7621/28/88 I2C | expand |
On Mon, Jun 17, 2019 at 10:31:16AM +0200, Stefan Roese wrote: > Add bindings for the I2C controller that can be found in the MediaTek > MT7621/7628/7688 SoCs. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> CCing the DT mailing list. > --- > v4: > - No change > > v3: > - New patch > > .../devicetree/bindings/i2c/i2c-mt7621.txt | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > new file mode 100644 > index 000000000000..bc36f0eb94cd > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > @@ -0,0 +1,25 @@ > +MediaTek MT7621/MT7628 I2C master controller > + > +Required properties: > + > +- compatible: Should be one of the following: > + - "mediatek,mt7621-i2c": for MT7621/MT7628/MT7688 platforms > +- #address-cells: should be 1. > +- #size-cells: should be 0. > +- reg: Address and length of the register set for the device > +- resets: phandle to the reset controller asserting this device in > + reset > + See ../reset/reset.txt for details. > + > +Optional properties : > + > +Example: > + > +i2c: i2c@900 { > + compatible = "mediatek,mt7621-i2c"; > + reg = <0x900 0x100>; > + #address-cells = <1>; > + #size-cells = <0>; > + resets = <&rstctrl 16>; > + reset-names = "i2c"; > +}; > -- > 2.22.0 >
On Mon, Jun 17, 2019 at 12:11:13PM +0200, Wolfram Sang wrote: > On Mon, Jun 17, 2019 at 10:31:16AM +0200, Stefan Roese wrote: > > Add bindings for the I2C controller that can be found in the MediaTek > > MT7621/7628/7688 SoCs. > > > > Signed-off-by: Stefan Roese <sr@denx.de> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > > CCing the DT mailing list. Since the driver has now clock support, don't we need bindings for this? > > > --- > > v4: > > - No change > > > > v3: > > - New patch > > > > .../devicetree/bindings/i2c/i2c-mt7621.txt | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > > new file mode 100644 > > index 000000000000..bc36f0eb94cd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt > > @@ -0,0 +1,25 @@ > > +MediaTek MT7621/MT7628 I2C master controller > > + > > +Required properties: > > + > > +- compatible: Should be one of the following: > > + - "mediatek,mt7621-i2c": for MT7621/MT7628/MT7688 platforms > > +- #address-cells: should be 1. > > +- #size-cells: should be 0. > > +- reg: Address and length of the register set for the device > > +- resets: phandle to the reset controller asserting this device in > > + reset > > + See ../reset/reset.txt for details. > > + > > +Optional properties : > > + > > +Example: > > + > > +i2c: i2c@900 { > > + compatible = "mediatek,mt7621-i2c"; > > + reg = <0x900 0x100>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + resets = <&rstctrl 16>; > > + reset-names = "i2c"; > > +}; > > -- > > 2.22.0 > >
On 17.06.19 12:14, Wolfram Sang wrote: > On Mon, Jun 17, 2019 at 12:11:13PM +0200, Wolfram Sang wrote: >> On Mon, Jun 17, 2019 at 10:31:16AM +0200, Stefan Roese wrote: >>> Add bindings for the I2C controller that can be found in the MediaTek >>> MT7621/7628/7688 SoCs. >>> >>> Signed-off-by: Stefan Roese <sr@denx.de> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> >> >> CCing the DT mailing list. > > Since the driver has now clock support, don't we need bindings for this? No. As the clock support is currently not handled via a DT based driver: https://elixir.bootlin.com/linux/v5.2-rc5/source/arch/mips/ralink/mt7620.c#L565 This probably should be moved to DT but would like to do this at a later time (if time permits). Thanks, Stefan
> This probably should be moved to DT but would like to do this at a > later time (if time permits). OK, thanks for the heads up.
On Mon, Jun 17, 2019 at 10:31:16AM +0200, Stefan Roese wrote: > Add bindings for the I2C controller that can be found in the MediaTek > MT7621/7628/7688 SoCs. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-next, thanks!
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt new file mode 100644 index 000000000000..bc36f0eb94cd --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt @@ -0,0 +1,25 @@ +MediaTek MT7621/MT7628 I2C master controller + +Required properties: + +- compatible: Should be one of the following: + - "mediatek,mt7621-i2c": for MT7621/MT7628/MT7688 platforms +- #address-cells: should be 1. +- #size-cells: should be 0. +- reg: Address and length of the register set for the device +- resets: phandle to the reset controller asserting this device in + reset + See ../reset/reset.txt for details. + +Optional properties : + +Example: + +i2c: i2c@900 { + compatible = "mediatek,mt7621-i2c"; + reg = <0x900 0x100>; + #address-cells = <1>; + #size-cells = <0>; + resets = <&rstctrl 16>; + reset-names = "i2c"; +};
Add bindings for the I2C controller that can be found in the MediaTek MT7621/7628/7688 SoCs. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Rob Herring <robh@kernel.org> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> --- v4: - No change v3: - New patch .../devicetree/bindings/i2c/i2c-mt7621.txt | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt7621.txt