| Message ID | 1560642311-25585-1-git-send-email-pthombar@cadence.com |
|---|---|
| Headers | show |
| Series | net: macb patch set cover letter | expand |
Hi All, Please ignore patches sent in-reply chain to patch 0001. Sending all patches in reply to patch 0000-cover-letter.patch. Regards, Parshuram Thombare >-----Original Message----- >From: Parshuram Thombare <pthombar@cadence.com> >Sent: Sunday, June 16, 2019 5:15 AM >To: andrew@lunn.ch; nicolas.ferre@microchip.com; davem@davemloft.net; >f.fainelli@gmail.com >Cc: netdev@vger.kernel.org; hkallweit1@gmail.com; linux- >kernel@vger.kernel.org; Rafal Ciepiela <rafalc@cadence.com>; Anil Joy >Varughese <aniljoy@cadence.com>; Piotr Sroka <piotrs@cadence.com>; >Parshuram Raju Thombare <pthombar@cadence.com> >Subject: [PATCH 0/6] net: macb patch set cover letter > >Hello !, > >This is second version of patch set containing following patches for Cadence >ethernet controller driver. > >1. 0001-net-macb-add-phylink-support.patch > Replace phylib API's with phylink API's. >2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch > This patch add support for SGMII mode. >3. 003-net-macb-add-PHY-configuration-in-MACB-PCI-wrapper.patch > This patch is to configure TI PHY DP83867 in SGMII mode from > our MAC PCI wrapper driver. > With this change there is no need of PHY driver and dp83867 > module must be disabled. Users wanting to setup DP83867 PHY > in SGMII mode can disable dp83867.ko driver, else dp83867.ko > overwrite this configuration and PHY is setup as per dp83867.ko. >4. 0004-net-macb-add-support-for-c45-PHY.patch > This patch is to support C45 PHY. >5. 0005-net-macb-add-support-for-high-speed-interface > This patch add support for 10G USXGMII PCS in fixed mode. > Since emulated PHY used in fixed mode doesn't seems to > support anything above 1G, additional parameter is used outside > "fixed-link" node for selecting speed and "fixed-link" > node speed is still set at 1G. >6. 0006-net-macb-parameter-added-to-cadence-ethernet-controller-DT-binding > New parameters added to Cadence ethernet controller DT binding > for USXGMII interface. > >Regards, >Parshuram Thombare > >Parshuram Thombare (6): > net: macb: add phylink support > net: macb: add support for sgmii MAC-PHY interface > net: macb: add PHY configuration in MACB PCI wrapper > net: macb: add support for c45 PHY > net: macb: add support for high speed interface > net: macb: parameter added to cadence ethernet controller DT binding > > .../devicetree/bindings/net/macb.txt | 4 + > drivers/net/ethernet/cadence/Kconfig | 2 +- > drivers/net/ethernet/cadence/macb.h | 136 +++- > drivers/net/ethernet/cadence/macb_main.c | 659 ++++++++++++++---- > drivers/net/ethernet/cadence/macb_pci.c | 225 ++++++ > 5 files changed, 860 insertions(+), 166 deletions(-) > >-- >2.17.1
> 3. 003-net-macb-add-PHY-configuration-in-MACB-PCI-wrapper.patch > This patch is to configure TI PHY DP83867 in SGMII mode from > our MAC PCI wrapper driver. > With this change there is no need of PHY driver and dp83867 > module must be disabled. Users wanting to setup DP83867 PHY > in SGMII mode can disable dp83867.ko driver, else dp83867.ko > overwrite this configuration and PHY is setup as per dp83867.ko. This sounds very wrong. Why not make the dp83867 driver support SGMII? Andrew
> 5. 0005-net-macb-add-support-for-high-speed-interface > This patch add support for 10G USXGMII PCS in fixed mode. > Since emulated PHY used in fixed mode doesn't seems to > support anything above 1G, additional parameter is used outside > "fixed-link" node for selecting speed and "fixed-link" > node speed is still set at 1G. PHYLINK does support higher speeds for fixed-link. Andrew
As this change doesn't affect other users I thought it is safe to do it from PCI wrapper driver. But yes I agree that right way is to do it in PHY driver. I would like to drop this patch, please ignore only this patch from series. >-----Original Message----- >From: Andrew Lunn <andrew@lunn.ch> >Sent: Monday, June 17, 2019 8:35 PM >To: Parshuram Raju Thombare <pthombar@cadence.com> >Cc: nicolas.ferre@microchip.com; davem@davemloft.net; f.fainelli@gmail.com; >netdev@vger.kernel.org; hkallweit1@gmail.com; linux-kernel@vger.kernel.org; >Rafal Ciepiela <rafalc@cadence.com>; Anil Joy Varughese ><aniljoy@cadence.com>; Piotr Sroka <piotrs@cadence.com> >Subject: Re: [PATCH 0/6] net: macb patch set cover letter > >EXTERNAL MAIL > > >> 3. 003-net-macb-add-PHY-configuration-in-MACB-PCI-wrapper.patch >> This patch is to configure TI PHY DP83867 in SGMII mode from >> our MAC PCI wrapper driver. >> With this change there is no need of PHY driver and dp83867 >> module must be disabled. Users wanting to setup DP83867 PHY >> in SGMII mode can disable dp83867.ko driver, else dp83867.ko >> overwrite this configuration and PHY is setup as per dp83867.ko. > >This sounds very wrong. Why not make the dp83867 driver support SGMII? > > Andrew Regards, Parshuram Thombare
Speed limitation of emulated PHY was because there was existing code trying to register/emulate PHY for fixed mode. By removing code to register emulated PHY for fixed mode I am able to get fixed 10G link up and running. I will send next version of patch. >-----Original Message----- >From: Andrew Lunn <andrew@lunn.ch> >Sent: Monday, June 17, 2019 8:38 PM >To: Parshuram Raju Thombare <pthombar@cadence.com> >Cc: nicolas.ferre@microchip.com; davem@davemloft.net; f.fainelli@gmail.com; >netdev@vger.kernel.org; hkallweit1@gmail.com; linux-kernel@vger.kernel.org; >Rafal Ciepiela <rafalc@cadence.com>; Anil Joy Varughese ><aniljoy@cadence.com>; Piotr Sroka <piotrs@cadence.com> >Subject: Re: [PATCH 0/6] net: macb patch set cover letter > >EXTERNAL MAIL > > >> 5. 0005-net-macb-add-support-for-high-speed-interface >> This patch add support for 10G USXGMII PCS in fixed mode. >> Since emulated PHY used in fixed mode doesn't seems to >> support anything above 1G, additional parameter is used outside >> "fixed-link" node for selecting speed and "fixed-link" >> node speed is still set at 1G. > >PHYLINK does support higher speeds for fixed-link. > > Andrew Regards, Parshuram Thombare