| Message ID | 20190606211414.8681-1-crosa@redhat.com |
|---|---|
| Headers | show |
| Series | Add "boot_linux" acceptance test | expand |
Patchew URL: https://patchew.org/QEMU/20190606211414.8681-1-crosa@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v6 0/7] Add "boot_linux" acceptance test
Type: series
Message-id: 20190606211414.8681-1-crosa@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190606211414.8681-1-crosa@redhat.com -> patchew/20190606211414.8681-1-crosa@redhat.com
Switched to a new branch 'test'
7362d67bed use Avocado data drainer for console logging
1c6ac71e07 Add "boot_linux" test for aarch64 and virt machine type
76dfc6e28e Add "boot_linux" test for x86_64 and pc and q35 machine types
01a69804c2 Acceptance tests: depend on qemu-img
b7dc969d31 Acceptance tests: add the build directory to the system PATH
5f3b84c3b6 Acceptance tests: keep a stable reference to the QEMU build dir
8d08990c7c Acceptance tests: use relative location for tests
=== OUTPUT BEGIN ===
1/7 Checking commit 8d08990c7c78 (Acceptance tests: use relative location for tests)
2/7 Checking commit 5f3b84c3b6f7 (Acceptance tests: keep a stable reference to the QEMU build dir)
ERROR: line over 90 characters
#48: FILE: tests/acceptance/avocado_qemu/__init__.py:17:
+SRC_ROOT_DIR = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
total: 1 errors, 0 warnings, 8 lines checked
Patch 2/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/7 Checking commit b7dc969d311a (Acceptance tests: add the build directory to the system PATH)
4/7 Checking commit 01a69804c2b2 (Acceptance tests: depend on qemu-img)
5/7 Checking commit 76dfc6e28e21 (Add "boot_linux" test for x86_64 and pc and q35 machine types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
WARNING: line over 80 characters
#107: FILE: tests/acceptance/boot_linux.py:60:
+ cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), self.name)
total: 0 errors, 2 warnings, 96 lines checked
Patch 5/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit 1c6ac71e07f2 (Add "boot_linux" test for aarch64 and virt machine type)
7/7 Checking commit 7362d67bed37 (use Avocado data drainer for console logging)
WARNING: line over 80 characters
#38: FILE: tests/acceptance/boot_linux.py:62:
+ console_drainer = datadrainer.LineLogger(self.vm.console_socket.fileno(),
WARNING: line over 80 characters
#39: FILE: tests/acceptance/boot_linux.py:63:
+ logger=self.log.getChild('console'))
total: 0 errors, 2 warnings, 50 lines checked
Patch 7/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190606211414.8681-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
This adds an acceptance test that validates that a full blown Linux guest can successfully boot in QEMU. Changes from v5: ================ * Added explicit "--enable-slirp=git" to Travis CI configure line, as these tests depend on "-netdev user" like networking. * Bumped Fedora to most recently released version (30). * Changed "checksum" parameter to 'sha256' and use the same hashes as provided by the Fedora project (instead of using Avocado's default sha1 and compute and use a different hash value). * New commit: Add "boot_linux" test for aarch64 and virt machine type * New commit: [RFC]: use Avocado data drainer for console logging Changes from v4: ================ * New commit "Acceptance tests: use relative location for tests" * New commit "Acceptance tests: keep a stable reference to the QEMU build dir" * Pinned the Fedora 29 image by adding a checksum. The goal is to never allow more than one component to change at a time (the one allowed to change is QEMU itself). Updates to the image should be manual. (Based on comments from Cornelia) * Moved the downloading of the Fedora 29 cloud image to the test setUp() method, canceling the test if the image can not be downloaded. * Removed the ":avocado: enable" tag, given that Avocado versions 68.0 and later operate on a "recursive by default" manner, that is able to correctly identify this as an Avocado test. Changes from v3: ================ * New patch "Acceptance tests: depend on qemu-img" Known Issues on v3 (no longer applicable): ========================================== * A recent TCG performance regression[1] affects this test in a number of ways: - The test execution may timeout by itself - The generation of SSH host keys in the guest's first boot is also affected (possibly also a timeout) - The cloud-init "phone home" feature attempts to read the host keys and fails, causing the test to timeout and fail These are not observed anymore once the fix[2] is applied. [1] - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00338.html [2] - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01129.html Changes from v2: ================ * Updated the tag to include the "arch:" key, in a similar fashion as to the tests in the "Acceptance Tests: target architecture support": - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00369.html * Renamed the test method name to test_x86_64_pc, again, similarly to the boot_linux_console.py tests in the series mentioned before. * Set the machine type explicitly, again similarly to the boot_linux_console.py tests in the series mentioned before. * Added messages after the launch of the VM, to let test runners know the test know waits for a boot confirmation from the the guest (Eduardo). * Updated commit message to reflect the fact that this version does not allow for parameterization of the guest OS, version, etc. * Dropped the RFC prefix on patch "RFC: Acceptance tests: add the build directory to the system PATH" * Changed the comments on "RFC: Acceptance tests: add the build directory to the system PATH" to make it clear the addition of a the build directory to the PATH may influence other utility code. Changes from v1: ================ * The commit message was adjusted, removing the reference to the avocado.utils.vmimage encoding issue on previous Avocado versions (<= 64.0) and the fix that would (and was) included in Avocado version 65.0. * Effectively added pycdlib==1.6.0 to the requirements.txt file, added on a56931eef3, and adjusted the commit message was also to reflect that. * Updated the default version of the guest OS, from Fedora 28 to 29. Besides possible improvements in the (virtual) hardware coverage, it brings a performance improvement in the order of 20% to the test. * Removed all direct parameters usage. Because some parameters and its default values implemented in the test would prevent it from running on some environments. Example: the "accel" parameter had a default value of "kvm", which would prevent this test, that boots a x86_64 OS, from running on a host arch different than x86_64. I recognize that it's desirable to make tests reusable and parameterized (that was the reason for the first version doing so), but the mechanism to be used to define the architectures that a given test should support is still an open issue, and has been discussed in other threads. I'll follow up those discussions with a proposal, and until then, removing those aspects from this test implementation seemed to be the best option. A caveat: this test currently adds the same tag (x86_64) and follows other assumptions made on "boot_linux_console.py", that is, that a x86_64 target binary will be used to run it. If a user is in an environment that does not have a x86_64 target binary, it could filter those tests out with: "avocado run --filter-by-tags='-x86_64' tests/acceptance". * Removed most arguments to the QEMU command line for pretty much the same reasons described above, and by following the general perception that I could grasp from other discussions that QEMU defaults should preferrably be used. This test, as well as others, can and should be extended later to allow for different test scenarios by passing well documented parameter values. That is, they should respect well-known parameters such as "accel" mentioned above, so that the same test can run with KVM or TCG. * Changed the value of the memory argument to 1024, which based on my experimentations and observations is the minimum amount of RAM for the Fedora 29 cloud image to sucessfully boot on QEMU. I know there's no such thing as a "one size fits all", specially for QEMU, but this makes me wonder wether a x86_64 machine type shouldn't have its default_ram_size bumped to a number practical enough to run modern operating systems. * Added a new patch "RFC: Acceptance tests: add the build directory to the system PATH", which is supposed to gather feedback on how to enable the use of built binaries, such as qemu-img, to code used by the test code. The specific situation here is that the vmimage, part of the avocado.utils libraries, makes use of qemu-img to create snapshot files. Even though we could require qemu-img to be installed as a dependency of tests, system wide, it actually goes against the goal of testing all QEMU things from the source/build tree. This became aparent with tests running on environments such as Travis CI, which don't necessarily have qemu-img available elsewhere. Some hopefully useful pointers for reviewers: ============================================= Git Info: - URI: https://github.com/clebergnu/qemu/tree/test_boot_linux_v6 - Remote: https://github.com/clebergnu/qemu - Branch: test_boot_linux_v6 Travis CI Info: - Build: https://travis-ci.org/clebergnu/qemu/builds/542474730 - Job: https://travis-ci.org/clebergnu/qemu/jobs/542474755 Previous version: - v5: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04652.html - v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02032.html - v3: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01677.html - v2: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04318.html - v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02530.html Cleber Rosa (7): Acceptance tests: use relative location for tests Acceptance tests: keep a stable reference to the QEMU build dir Acceptance tests: add the build directory to the system PATH Acceptance tests: depend on qemu-img Add "boot_linux" test for x86_64 and pc and q35 machine types Add "boot_linux" test for aarch64 and virt machine type [RFC]: use Avocado data drainer for console logging .travis.yml | 2 +- tests/Makefile.include | 4 +- tests/acceptance/avocado_qemu/__init__.py | 8 +- tests/acceptance/boot_linux.py | 111 ++++++++++++++++++++++ tests/requirements.txt | 4 +- 5 files changed, 124 insertions(+), 5 deletions(-) create mode 100644 tests/acceptance/boot_linux.py