diff mbox series

[1/2] dt-bindings: socfpga-dwmac: add "altr,socfpga-stmmac-a10-s10" binding

Message ID 20190605150551.12791-1-dinguyen@kernel.org
State Accepted
Delegated to: David Miller
Headers show
Series [1/2] dt-bindings: socfpga-dwmac: add "altr,socfpga-stmmac-a10-s10" binding | expand

Commit Message

Dinh Nguyen June 5, 2019, 3:05 p.m. UTC
Add the "altr,socfpga-stmmac-a10-s10" binding for Arria10/Agilex/Stratix10
implementation of the stmmac ethernet controller.

On the Arria10, Agilex, and Stratix10 SoCs, there are a few differences from
the Cyclone5 and Arria5:
     - The emac PHY setup bits are in separate registers.
     - The PTP reference clock select mask is different.
     - The register to enable the emac signal from FPGA is different.

Because of these differences, the dwmac-socfpga glue logic driver will
use this new binding to set the appropriate bits for PHY, PTP reference
clock, and signal from FPGA.

Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 .../devicetree/bindings/net/socfpga-dwmac.txt          | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

David Miller June 6, 2019, 9:21 p.m. UTC | #1
From: Dinh Nguyen <dinguyen@kernel.org>
Date: Wed,  5 Jun 2019 10:05:50 -0500

> Add the "altr,socfpga-stmmac-a10-s10" binding for Arria10/Agilex/Stratix10
> implementation of the stmmac ethernet controller.
> 
> On the Arria10, Agilex, and Stratix10 SoCs, there are a few differences from
> the Cyclone5 and Arria5:
>      - The emac PHY setup bits are in separate registers.
>      - The PTP reference clock select mask is different.
>      - The register to enable the emac signal from FPGA is different.
> 
> Because of these differences, the dwmac-socfpga glue logic driver will
> use this new binding to set the appropriate bits for PHY, PTP reference
> clock, and signal from FPGA.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>

Applied to net-next.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
index 17d6819669c8..612a8e8abc88 100644
--- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
@@ -6,11 +6,17 @@  present in Documentation/devicetree/bindings/net/stmmac.txt.
 The device node has additional properties:
 
 Required properties:
- - compatible	: Should contain "altr,socfpga-stmmac" along with
-		  "snps,dwmac" and any applicable more detailed
+ - compatible	: For Cyclone5/Arria5 SoCs it should contain
+		  "altr,socfpga-stmmac". For Arria10/Agilex/Stratix10 SoCs
+		  "altr,socfpga-stmmac-a10-s10".
+		  Along with "snps,dwmac" and any applicable more detailed
 		  designware version numbers documented in stmmac.txt
  - altr,sysmgr-syscon : Should be the phandle to the system manager node that
    encompasses the glue register, the register offset, and the register shift.
+   On Cyclone5/Arria5, the register shift represents the PHY mode bits, while
+   on the Arria10/Stratix10/Agilex platforms, the register shift represents
+   bit for each emac to enable/disable signals from the FPGA fabric to the
+   EMAC modules.
  - altr,f2h_ptp_ref_clk use f2h_ptp_ref_clk instead of default eosc1 clock
    for ptp ref clk. This affects all emacs as the clock is common.