diff mbox series

[net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t'

Message ID 20190606144649.21368-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t' | expand

Commit Message

Yue Haibing June 6, 2019, 2:46 p.m. UTC
Fix sparse warning:

drivers/net/ethernet/mscc/ocelot_ace.c:96:3:
 warning: symbol 'vcap_data_t' was not declared. Should it be static?

'vcap_data_t' never used so can be removed

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller June 6, 2019, 6:37 p.m. UTC | #1
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 6 Jun 2019 22:46:49 +0800

> Fix sparse warning:
> 
> drivers/net/ethernet/mscc/ocelot_ace.c:96:3:
>  warning: symbol 'vcap_data_t' was not declared. Should it be static?
> 
> 'vcap_data_t' never used so can be removed
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.  I am pretty sure this was meant to be a typedef.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
index 34d8260..f74b98f 100644
--- a/drivers/net/ethernet/mscc/ocelot_ace.c
+++ b/drivers/net/ethernet/mscc/ocelot_ace.c
@@ -93,7 +93,7 @@  struct vcap_data {
 	u32 counter_offset; /* Current counter offset */
 	u32 tg_value; /* Current type-group value */
 	u32 tg_mask; /* Current type-group mask */
-} vcap_data_t;
+};
 
 static u32 vcap_s2_read_update_ctrl(struct ocelot *oc)
 {