| Message ID | 1559599037-8514-7-git-send-email-hancock@sedsystems.ca |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | Xilinx axienet driver updates (v2) | expand |
On Mon, Jun 03, 2019 at 03:57:05PM -0600, Robert Hancock wrote: > Since the MDIO is is brought up before the netdev is registered, it > should be torn down after the netdev is removed. Otherwise, PHY accesses > can potentially access freed MDIO bus references and cause a crash. > > Signed-off-by: Robert Hancock <hancock@sedsystems.ca> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 09a489d..0c13261 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1641,8 +1641,8 @@ static int axienet_remove(struct platform_device *pdev) struct net_device *ndev = platform_get_drvdata(pdev); struct axienet_local *lp = netdev_priv(ndev); - axienet_mdio_teardown(lp); unregister_netdev(ndev); + axienet_mdio_teardown(lp); of_node_put(lp->phy_node); lp->phy_node = NULL;
Since the MDIO is is brought up before the netdev is registered, it should be torn down after the netdev is removed. Otherwise, PHY accesses can potentially access freed MDIO bus references and cause a crash. Signed-off-by: Robert Hancock <hancock@sedsystems.ca> --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)