| Message ID | ec750ff0021c942b3c477e1cc7dc35f957600c96.1558471150.git.leonard.crestez@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | mfd: bd718x7: Set button press duration via dt only | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 18 lines checked" |
On Tue, 21 May 2019, Leonard Crestez wrote: > These values can be overwritten at probe time. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) Applied, thanks.
On Tue, May 21, 2019 at 08:41:13PM +0000, Leonard Crestez wrote: > These values can be overwritten at probe time. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt > index d5f68ac78d15..3649c1191432 100644 > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt > @@ -36,10 +36,18 @@ switched power state to SNVS. If reset is done via READY state the power > outputs will be returned to HW control by OTP loading. Thus the reset > target state is set to READY by default. If SNVS state is used the boot > crucial regulators must have the regulator-always-on and regulator-boot-on > properties set in regulator node. > > +- rohm,short-press-ms : Short press duration in milliseconds > +- rohm,long-press-ms : Long press duration in milliseconds > + > +Configure the "short press" and "long press" timers for the power button. > +Values are rounded to what hardware supports (500ms multiple for short and > +1000ms multiple for long). If these properties are not present the existing > +configuration (from bootloader or OTP) is not touched. We already have a standard property 'power-off-time-sec' for at least part of this assuming 'long' or 'short' causes a power off. 'long' and 'short' don't describe anything useful. The action should be described. Rob
diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt index d5f68ac78d15..3649c1191432 100644 --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt @@ -36,10 +36,18 @@ switched power state to SNVS. If reset is done via READY state the power outputs will be returned to HW control by OTP loading. Thus the reset target state is set to READY by default. If SNVS state is used the boot crucial regulators must have the regulator-always-on and regulator-boot-on properties set in regulator node. +- rohm,short-press-ms : Short press duration in milliseconds +- rohm,long-press-ms : Long press duration in milliseconds + +Configure the "short press" and "long press" timers for the power button. +Values are rounded to what hardware supports (500ms multiple for short and +1000ms multiple for long). If these properties are not present the existing +configuration (from bootloader or OTP) is not touched. + Example: /* external oscillator node */ osc: oscillator { compatible = "fixed-clock";