diff mbox series

[U-Boot,v4,8/8] pico-imx7d: enable boot without PMIC

Message ID 1557297516-18616-9-git-send-email-jun.nie@linaro.org
State Accepted
Commit c72a23701bd9b15dab35e0d43c468ab051739af3
Delegated to: Stefano Babic
Headers show
Series pico-imx7d: Add support for BL33 case | expand

Commit Message

Jun Nie May 8, 2019, 6:38 a.m. UTC
If PMIC is not probed successfully, it is still OK to boot
with default configuration although power is not optimized.

Default voltage of SW1A/SW1B is 1.1V/1.0V for PC32PF3000A1EP
on pico according to table 42 of spec of PF3000 ver 9.0.

Default mode of SW1A/SW1B is APS as expected(table 47).

Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
 board/technexion/pico-imx7d/pico-imx7d.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Fabio Estevam May 30, 2019, 11:58 p.m. UTC | #1
On Wed, May 8, 2019 at 3:39 AM Jun Nie <jun.nie@linaro.org> wrote:
>
> If PMIC is not probed successfully, it is still OK to boot

Are you getting PMIC probe failure?

What is the exact issue you are facing?
Jun Nie May 31, 2019, 3:28 a.m. UTC | #2
Fabio Estevam <festevam@gmail.com> 于2019年5月31日周五 上午7:58写道:
>
> On Wed, May 8, 2019 at 3:39 AM Jun Nie <jun.nie@linaro.org> wrote:
> >
> > If PMIC is not probed successfully, it is still OK to boot
>
> Are you getting PMIC probe failure?
>
> What is the exact issue you are facing?

There is no response from the PMIC I2C address in software test.
Fabio Estevam May 31, 2019, 10:38 a.m. UTC | #3
Hi Jun,

On Fri, May 31, 2019 at 12:29 AM Jun Nie <jun.nie@linaro.org> wrote:

> There is no response from the PMIC I2C address in software test.

Please fix this issue instead of proceeding with a failure on PMIC probe.
Stefano Babic June 10, 2019, 9:49 a.m. UTC | #4
> If PMIC is not probed successfully, it is still OK to boot
> with default configuration although power is not optimized.
> Default voltage of SW1A/SW1B is 1.1V/1.0V for PC32PF3000A1EP
> on pico according to table 42 of spec of PF3000 ver 9.0.
> Default mode of SW1A/SW1B is APS as expected(table 47).
> Signed-off-by: Jun Nie <jun.nie@linaro.org>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index 5b357f2..e3d75e5 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -85,8 +85,11 @@  int power_init_board(void)
 
 	p = pmic_get("PFUZE3000");
 	ret = pmic_probe(p);
-	if (ret)
-		return ret;
+	if (ret) {
+		printf("Warning:  Cannot find PMIC PFUZE3000\n");
+		printf("\tPower consumption is not optimized.\n");
+		return 0;
+	}
 
 	pmic_reg_read(p, PFUZE3000_DEVICEID, &reg);
 	pmic_reg_read(p, PFUZE3000_REVID, &rev_id);