| Message ID | 20190529221523.22399-5-bigeasy@linutronix.de |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | Avoid local_irq_save() and use napi_alloc_frag() where possible | expand |
> -----Original Message----- > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Sent: Thursday, May 30, 2019 1:15 AM > To: netdev@vger.kernel.org > Cc: tglx@linutronix.de; David S. Miller <davem@davemloft.net>; Sebastian > Andrzej Siewior <bigeasy@linutronix.de>; Ioana Ciocoi Radulescu > <ruxandra.radulescu@nxp.com> > Subject: [PATCH net-next 4/7] dpaa2-eth: Use napi_alloc_frag() > > The driver is using netdev_alloc_frag() for allocation in the > ->ndo_start_xmit() path. That one is always invoked in a BH disabled > region so we could also use napi_alloc_frag(). > > Use napi_alloc_frag() for skb allocation. > > Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Ioana Radulescu <ruxandra.radulescu@nxp.com> Thanks, Ioana
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index f9ae97ba63334..ffeec89c0985e 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -555,7 +555,7 @@ static int build_sg_fd(struct dpaa2_eth_priv *priv, /* Prepare the HW SGT structure */ sgt_buf_size = priv->tx_data_offset + sizeof(struct dpaa2_sg_entry) * num_dma_bufs; - sgt_buf = netdev_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN); + sgt_buf = napi_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN); if (unlikely(!sgt_buf)) { err = -ENOMEM; goto sgt_buf_alloc_failed;
The driver is using netdev_alloc_frag() for allocation in the ->ndo_start_xmit() path. That one is always invoked in a BH disabled region so we could also use napi_alloc_frag(). Use napi_alloc_frag() for skb allocation. Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)