Message ID | 20190528132034.3908-1-daniel.baluta@nxp.com |
---|---|
Headers | show |
Series | Add mclk0 clock source for SAI | expand |
On Tue, May 28, 2019 at 01:21:00PM +0000, Daniel Baluta wrote: > From: Shengjiu Wang <shengjiu.wang@nxp.com> > > Audio MCLK source option is selected with a 4:1 MUX > controller using MCLK Select bits in SAI xCR2 register. > > On imx6/7 mclk0 and mclk1 always point to the same clock > source. Anyhow, this is no longer true for imx8. > > For this reason, we need to add mclk0 and handle it > in a generic way in SAI driver. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > arch/arm/boot/dts/imx6sx.dtsi | 6 ++++-- > arch/arm/boot/dts/imx6ul.dtsi | 9 ++++++--- > arch/arm/boot/dts/imx7s.dtsi | 9 ++++++--- These are dtsi/dts files that have SAI missing mclk0: arch/arm/boot/dts/imx6ul.dtsi arch/arm/boot/dts/imx6sx.dtsi arch/arm/boot/dts/ls1021a.dtsi arch/arm/boot/dts/imx7s.dtsi arch/arm/boot/dts/vfxxx.dtsi arch/arm64/boot/dts/freescale/imx8mq.dtsi arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi Would it be possible for you to update the others also? Thanks Nicolin
On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote: > 1) SAI clock source select MUX is really part of the hardware > 2) flexibility! We let DT tell us which is the option for MUX > option 0. I think the "MUX" is plausible comparing to your previous version. As long as DT maintainers ack the DT binding doc, I would be okay to ack too. Just one comments at the dts/dtsi changes, I know the driver would just warn old DTs, but it does change the behavior at the mclk_clk[0] from previously bus_clk to NULL after this series.
On Wed, 2019-05-29 at 16:03 -0700, Nicolin Chen wrote: > On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote: > > > 1) SAI clock source select MUX is really part of the hardware > > 2) flexibility! We let DT tell us which is the option for MUX > > option 0. > > I think the "MUX" is plausible comparing to your previous version. > As long as DT maintainers ack the DT binding doc, I would be okay > to ack too. Just one comments at the dts/dtsi changes, I know the > driver would just warn old DTs, but it does change the behavior at > the mclk_clk[0] from previously bus_clk to NULL after this series. Thanks for review, will fix in v2.