Message ID | 20190525162323.20216-1-peron.clem@gmail.com |
---|---|
Headers | show |
Series | Allwinner H6 SPDIF support | expand |
On Sat, May 25, 2019 at 06:23:18PM +0200, Clément Péron wrote: > The quirks are actually defines in the middle of the file with > short explanation. > > Move this at the top and add a section to have coherency with > sun4i-i2s. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Sat, May 25, 2019 at 06:23:19PM +0200, Clément Péron wrote: > Allwinner H6 has a different bit to flush the TX FIFO. > > Add a quirks to prepare introduction of H6 SoC. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > sound/soc/sunxi/sun4i-spdif.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index b6c66a62e915..8317bbee0712 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -166,10 +166,12 @@ > * > * @reg_dac_tx_data: TX FIFO offset for DMA config. > * @has_reset: SoC needs reset deasserted. > + * @reg_fctl_ftx: TX FIFO flush bitmask. It's a bit weird to use the same prefix for a register offset (reg_dac_tx_data) and a value (reg_fctl_ftx). Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Sat, May 25, 2019 at 06:23:21PM +0200, Clément Péron wrote: > The Allwinner H6 has a SPDIF controller called OWA (One Wire Audio). > > Only one pinmuxing is available so set it as default. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 ++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > index f4ea596c82ce..307d3c896ff2 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -83,6 +83,24 @@ > method = "smc"; > }; > > + sound_spdif { This generates a warning in DTC, underscores are not valid characters for a node name. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Maxime, On Sun, 26 May 2019 at 20:24, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Sat, May 25, 2019 at 06:23:19PM +0200, Clément Péron wrote: > > Allwinner H6 has a different bit to flush the TX FIFO. > > > > Add a quirks to prepare introduction of H6 SoC. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > sound/soc/sunxi/sun4i-spdif.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > > index b6c66a62e915..8317bbee0712 100644 > > --- a/sound/soc/sunxi/sun4i-spdif.c > > +++ b/sound/soc/sunxi/sun4i-spdif.c > > @@ -166,10 +166,12 @@ > > * > > * @reg_dac_tx_data: TX FIFO offset for DMA config. > > * @has_reset: SoC needs reset deasserted. > > + * @reg_fctl_ftx: TX FIFO flush bitmask. > > It's a bit weird to use the same prefix for a register offset > (reg_dac_tx_data) and a value (reg_fctl_ftx). I just look at sun4i-codec and they use a regmap, But I think it's a bit overkill no? What do you think about val_fctl_ftx ? Thanks for your review, Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Sun, May 26, 2019 at 09:00:30PM +0200, Clément Péron wrote: > Hi Maxime, > > On Sun, 26 May 2019 at 20:24, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Sat, May 25, 2019 at 06:23:19PM +0200, Clément Péron wrote: > > > Allwinner H6 has a different bit to flush the TX FIFO. > > > > > > Add a quirks to prepare introduction of H6 SoC. > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > --- > > > sound/soc/sunxi/sun4i-spdif.c | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > > > index b6c66a62e915..8317bbee0712 100644 > > > --- a/sound/soc/sunxi/sun4i-spdif.c > > > +++ b/sound/soc/sunxi/sun4i-spdif.c > > > @@ -166,10 +166,12 @@ > > > * > > > * @reg_dac_tx_data: TX FIFO offset for DMA config. > > > * @has_reset: SoC needs reset deasserted. > > > + * @reg_fctl_ftx: TX FIFO flush bitmask. > > > > It's a bit weird to use the same prefix for a register offset > > (reg_dac_tx_data) and a value (reg_fctl_ftx). > > I just look at sun4i-codec and they use a regmap, But I think it's a > bit overkill no? For a single value, yeah > What do you think about val_fctl_ftx ? Looks good, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com