Message ID | cover.1558596599.git.joabreu@synopsys.com |
---|---|
Headers | show |
Series | net: stmmac: Improvements and Selftests | expand |
From: Jose Abreu <Jose.Abreu@synopsys.com> Date: Thu, 23 May 2019 09:36:50 +0200 > [ Thanks to the introducion of selftests this series ended up being a misc > of improvements and the selftests additions per-se. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests can easily be added in the future and can be run in virtually > any MAC/GMAC/QoS/XGMAC platform. > > Having this we can find regressions and missing features in the driver > while at the same time we can check if the IP is correctly working. > > We have been using this for some time now and I do have more tests to > submit in the feature. My experience is that although writing the tests > adds more development time, the gain results are obvious. > > I let this feature optional within the driver under a Kconfig option. Series applied.
From: David Miller <davem@davemloft.net> Date: Thu, 23 May 2019 09:09:28 -0700 (PDT) > Series applied. I'm reverting, this doesn't even build. ERROR: "dev_set_rx_mode" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined! make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 make: *** [Makefile:1290: modules] Error 2 Always test your driver both modular and static when referencing new symbols.
From: David Miller <davem@davemloft.net> Date: Thu, May 23, 2019 at 17:18:14 > I'm reverting, this doesn't even build. Damn, sorry! I failed to notice that dev_set_rx_mode() is not exported :/ I will fix and resend! Thanks, Jose Miguel Abreu