diff mbox

net: forcedeth: fix compile warning of not used nv_set_tso function

Message ID 4DAE3768.9030807@cn.fujitsu.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Shan Wei April 20, 2011, 1:31 a.m. UTC
Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

commit 569e146 converts forcedeth driver to use hw_features.
So, implement function of .set_tso is abandoned.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
---
 drivers/net/forcedeth.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

Comments

Shan Wei April 20, 2011, 1:42 a.m. UTC | #1
This patch is against net-next.

Shan Wei wrote, at 04/20/2011 09:31 AM:
> Fix the below compile warning:
> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
> 
> commit 569e146 converts forcedeth driver to use hw_features.
> So, implement function of .set_tso is abandoned.
> 
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> ---
>  drivers/net/forcedeth.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index ec9a32d..0e1c76a 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
>  	return ret;
>  }
>  
> -static int nv_set_tso(struct net_device *dev, u32 value)
> -{
> -	struct fe_priv *np = netdev_priv(dev);
> -
> -	if ((np->driver_data & DEV_HAS_CHECKSUM))
> -		return ethtool_op_set_tso(dev, value);
> -	else
> -		return -EOPNOTSUPP;
> -}
> -
>  static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
>  {
>  	struct fe_priv *np = netdev_priv(dev);
David Miller April 20, 2011, 3:11 a.m. UTC | #2
From: Shan Wei <shanwei@cn.fujitsu.com>

Date: Wed, 20 Apr 2011 09:31:20 +0800

> Fix the below compile warning:

> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

> 

> commit 569e146 converts forcedeth driver to use hw_features.

> So, implement function of .set_tso is abandoned.

> 

> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>


Applied.
diff mbox

Patch

diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index ec9a32d..0e1c76a 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -4263,16 +4263,6 @@  static int nv_nway_reset(struct net_device *dev)
 	return ret;
 }
 
-static int nv_set_tso(struct net_device *dev, u32 value)
-{
-	struct fe_priv *np = netdev_priv(dev);
-
-	if ((np->driver_data & DEV_HAS_CHECKSUM))
-		return ethtool_op_set_tso(dev, value);
-	else
-		return -EOPNOTSUPP;
-}
-
 static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
 {
 	struct fe_priv *np = netdev_priv(dev);