mbox series

[-next,0/3] netfilter: header cleanup

Message ID 1555360996-23684-1-git-send-email-paul.gortmaker@windriver.com
Headers show
Series netfilter: header cleanup | expand

Message

Paul Gortmaker April 15, 2019, 8:43 p.m. UTC 
Having core header files in include/linux that in turn include other
headers with a high number of includes implicitly degenerates into
a formalism that hides what amounts to #include <linux/everything.h>

Some headers, like module.h and device.h are good examples that will
essentially drag in almost everything.

There is nothing module specific about netfilter, but before we try
and stop nf_tables.h from including module.h, we have to fix two
instances of code which are implicitly relying on that module.h
inclusion, so as to not introduce build regressions.

---

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Florian Westphal <fw@strlen.de>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org

Paul Gortmaker (3):
  netfilter: nf_tables: relocate header content to consumer
  netfilter: nf_tables: fix implicit include of module.h
  netfilter: nf_tables: drop include of module.h from nf_tables.h

 include/net/netfilter/nf_tables.h  | 20 ++------------------
 net/netfilter/nf_tables_set_core.c |  1 +
 net/netfilter/nft_dynset.c         | 17 +++++++++++++++++
 3 files changed, 20 insertions(+), 18 deletions(-)

Comments

Pablo Neira Ayuso April 30, 2019, 11:39 a.m. UTC | #1 
On Mon, Apr 15, 2019 at 04:43:13PM -0400, Paul Gortmaker wrote:
> Having core header files in include/linux that in turn include other
> headers with a high number of includes implicitly degenerates into
> a formalism that hides what amounts to #include <linux/everything.h>
> 
> Some headers, like module.h and device.h are good examples that will
> essentially drag in almost everything.
> 
> There is nothing module specific about netfilter, but before we try
> and stop nf_tables.h from including module.h, we have to fix two
> instances of code which are implicitly relying on that module.h
> inclusion, so as to not introduce build regressions.

Series applied.