| Message ID | 20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| Headers | show |
| Series | mtd: onenand/samsung: Add device tree support | expand |
Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 18:42:20 +0200: > From: Tomasz Figa <tomasz.figa@gmail.com> > > Before this patch, the order of memory resources requested by the driver > was controller base as first and OneNAND chip base as second for > S3C64xx/S5PC100 variant and the opposite for S5PC110/S5PV210 variant. > > To make this more consistent, this patch swaps the order of resources > for the latter and updates platform code accordingly. As a nice side > effect there is a slight reduction in line count of probe function. > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> Thanks for the patch but it looks like you also are renaming fields in the main onenand structure. Maybe it is worth doing it in a preliminary patch. Thanks, Miquèl
Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 18:42:21 +0200: > From: Tomasz Figa <tomasz.figa@gmail.com> > > This patch adds basic handling of controller bus clock to make sure that > in device probe it is enabled and device can operate correctly. The > clock is optional and driver behavior is identical as before this patch > if not provided. > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 18:42:19 +0200: > This patchset adds device tree support to Samsung OneNAND driver. > It was tested on Samsung Galaxy S and Samsung Galaxy S Fascinate 4G, > an Samsung S5PV210 based mobile phones. > > Tomasz Figa (5): > mtd: onenand/samsung: Unify resource order for controller variants > mtd: onenand/samsung: Make sure that bus clock is enabled > mtd: onenand/samsung: Add device tree support > dt-binding: mtd: onenand/samsung: Add device tree support > mtd: onenand/samsung: Set name field of mtd_info struct > > .../bindings/mtd/samsung-onenand.txt | 46 +++++++++ > drivers/mtd/nand/onenand/samsung.c | 94 +++++++++++++------ > 2 files changed, 113 insertions(+), 27 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/samsung-onenand.txt > I think you should use "mtd: onenand: samsung:" as prefix. Thanks, Miquèl
Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 18:42:22 +0200: > From: Tomasz Figa <tomasz.figa@gmail.com> > > This patch adds support for instantation using Device Tree. "Add support for..." is enough. Otherwise: Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Hi Paweł, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 18:42:24 +0200: > From: Tomasz Figa <tomasz.figa@gmail.com> > > This patch adds initialization of .name field of mtd_info struct to > avoid printing "(null)" in kernel log messages, such as: > > [ 1.942519] 1 ofpart partitions found on MTD device (null) > [ 1.949708] Creating 1 MTD partitions on "(null)": > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > drivers/mtd/nand/onenand/samsung.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c > index 0f450604412f..1fda1f324cc6 100644 > --- a/drivers/mtd/nand/onenand/samsung.c > +++ b/drivers/mtd/nand/onenand/samsung.c > @@ -886,6 +886,7 @@ static int s3c_onenand_probe(struct platform_device *pdev) > return -ENOMEM; > > this = (struct onenand_chip *) &mtd[1]; > + mtd->name = dev_name(&pdev->dev); > mtd->priv = this; > mtd->dev.of_node = np; > mtd->dev.parent = &pdev->dev; Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On poniedziałek, 29 kwietnia 2019 10:19:28 CEST Miquel Raynal wrote: > Hi Paweł, > > Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019 > 18:42:19 +0200: > > > This patchset adds device tree support to Samsung OneNAND driver. > > It was tested on Samsung Galaxy S and Samsung Galaxy S Fascinate 4G, > > an Samsung S5PV210 based mobile phones. > > > > Tomasz Figa (5): > > mtd: onenand/samsung: Unify resource order for controller variants > > mtd: onenand/samsung: Make sure that bus clock is enabled > > mtd: onenand/samsung: Add device tree support > > dt-binding: mtd: onenand/samsung: Add device tree support > > mtd: onenand/samsung: Set name field of mtd_info struct > > > > .../bindings/mtd/samsung-onenand.txt | 46 +++++++++ > > drivers/mtd/nand/onenand/samsung.c | 94 +++++++++++++------ > > 2 files changed, 113 insertions(+), 27 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mtd/samsung-onenand.txt > > > > I think you should use "mtd: onenand: samsung:" as prefix. > > Thanks, > Miquèl > Hi Miquèl I'll fix all issues and send new version of patchset. Thanks for review and comments