| Message ID | cover.1554184734.git.vilhelm.gray@gmail.com |
|---|---|
| Headers | show |
| Series | Introduce the Counter subsystem | expand |
On Tue, 2 Apr 2019 15:30:35 +0900 William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > Changes in v10: > - Fix minor typographical errors in documentation > - Merge the FlexTimer Module Quadrature decoder counter driver patches > > This revision is functionally identical to the last; changes in this > version were made to fix minor typos in the documentation files and also > to pull in the new FTM quadrature decoder counter driver. > > The Generic Counter API has been and is still in a feature freeze until > it is merged into the mainline. The following features will be > investigated after the merge: interrupt support for counter devices, and > a character device interface for low-latency applications. Hi William / al, So the question is how to move this forwards? I'm happy with how it turned out and the existing drivers we had in IIO are a lot cleaner under the counter subsystem (other than the backwards compatibility for those that ever existed in IIO). For those not following closely the situation is: 1. Counter drivers never really fitted that well in IIO, because IIO is focused on an abstraction of individual channels that just doesn't match to these devices. It's just the wrong model. 2. William tried hard in earlier proposals to extend IIO to support these devices well, but it became so convoluted and involved I advised him that we were better off with a separate subsystem. The amount of code overlap between the core IIO support for counters and the reset of IIO was become very small and it would have been a maintenance problem for both. https://lwn.net/Articles/729363/ gives some of the history 3. The new subsystem introduced by this series is fairly simple, clean and well aligned with the way these devices work. There are (I think) 4 initial drivers in this series from 4 different authors so it's got some practical review that way! There are a couple more drivers under development. Right now, not everyone is aware of this work and so we have had a few developers potentially waste their time writing IIO drivers (which are then ported to this) rather that starting with the counter subsystem. So what we are after is more review, or agreement that we can move this series forwards. For now the intent is that the counter subsystem will share the linux-iio mailing list etc but I don't think either William or I have any particularly strong views on how we actually handle the patches. I'm more than happy to take them through the IIO tree, if that works for everyone, particularly Greg as IIO goes through him after me. Once it is in a release, the cross dependency is broken and we can think about longer term approaches. So Greg and others, how do we make progress here? If there are any obvious reviewers not on the CC list, please do draw their attention to this. Thanks, Jonathan +CC linux-api as obviously one of the biggest areas for review is the new userspace ABI. > > Benjamin Gaignard (2): > counter: Add STM32 Timer quadrature encoder > dt-bindings: counter: Document stm32 quadrature encoder > > Fabrice Gasnier (2): > counter: stm32-lptimer: add counter device > dt-bindings: counter: Adjust dt-bindings for STM32 lptimer move > > Patrick Havelange (7): > include/fsl: add common FlexTimer #defines in a separate header. > drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #defines > drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer > #defines > dt-bindings: counter: ftm-quaddec > counter: add FlexTimer Module Quadrature decoder counter driver > counter: ftm-quaddec: Documentation: Add specific counter sysfs > documentation > LS1021A: dtsi: add ftm quad decoder entries > > William Breathitt Gray (7): > counter: Introduce the Generic Counter interface > counter: Documentation: Add Generic Counter sysfs documentation > docs: Add Generic Counter interface documentation > iio: 104-quad-8: Update license boilerplate > counter: 104-quad-8: Add Generic Counter interface support > counter: 104-quad-8: Documentation: Add Generic Counter sysfs > documentation > iio: counter: Add deprecation markings for IIO Counter attributes > > Documentation/ABI/testing/sysfs-bus-counter | 230 +++ > .../ABI/testing/sysfs-bus-counter-104-quad-8 | 36 + > .../ABI/testing/sysfs-bus-counter-ftm-quaddec | 16 + > Documentation/ABI/testing/sysfs-bus-iio | 8 + > .../testing/sysfs-bus-iio-counter-104-quad-8 | 16 + > .../bindings/counter/ftm-quaddec.txt | 18 + > .../{iio => }/counter/stm32-lptimer-cnt.txt | 0 > .../bindings/counter/stm32-timer-cnt.txt | 31 + > .../devicetree/bindings/mfd/stm32-lptimer.txt | 2 +- > .../devicetree/bindings/mfd/stm32-timers.txt | 7 + > Documentation/driver-api/generic-counter.rst | 342 ++++ > Documentation/driver-api/index.rst | 1 + > MAINTAINERS | 15 +- > arch/arm/boot/dts/ls1021a.dtsi | 28 + > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/clocksource/timer-fsl-ftm.c | 15 +- > drivers/{iio => }/counter/104-quad-8.c | 782 +++++++- > drivers/counter/Kconfig | 60 + > drivers/counter/Makefile | 10 + > drivers/counter/counter.c | 1567 +++++++++++++++++ > drivers/counter/ftm-quaddec.c | 356 ++++ > drivers/{iio => }/counter/stm32-lptimer-cnt.c | 361 +++- > drivers/counter/stm32-timer-cnt.c | 390 ++++ > drivers/iio/Kconfig | 1 - > drivers/iio/Makefile | 1 - > drivers/iio/counter/Kconfig | 34 - > drivers/iio/counter/Makefile | 8 - > drivers/pwm/pwm-fsl-ftm.c | 44 +- > include/linux/counter.h | 510 ++++++ > include/linux/counter_enum.h | 45 + > include/linux/fsl/ftm.h | 88 + > 32 files changed, 4877 insertions(+), 148 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-bus-counter > create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-104-quad-8 > create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-ftm-quaddec > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > rename Documentation/devicetree/bindings/{iio => }/counter/stm32-lptimer-cnt.txt (100%) > create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > create mode 100644 Documentation/driver-api/generic-counter.rst > rename drivers/{iio => }/counter/104-quad-8.c (44%) > create mode 100644 drivers/counter/Kconfig > create mode 100644 drivers/counter/Makefile > create mode 100644 drivers/counter/counter.c > create mode 100644 drivers/counter/ftm-quaddec.c > rename drivers/{iio => }/counter/stm32-lptimer-cnt.c (51%) > create mode 100644 drivers/counter/stm32-timer-cnt.c > delete mode 100644 drivers/iio/counter/Kconfig > delete mode 100644 drivers/iio/counter/Makefile > create mode 100644 include/linux/counter.h > create mode 100644 include/linux/counter_enum.h > create mode 100644 include/linux/fsl/ftm.h >
Hi! > +const char *const counter_count_direction_str[2] = { > + [COUNTER_COUNT_DIRECTION_FORWARD] = "forward", > + [COUNTER_COUNT_DIRECTION_BACKWARD] = "backward" > +}; > +EXPORT_SYMBOL_GPL(counter_count_direction_str); > + > +const char *const counter_count_mode_str[4] = { > + [COUNTER_COUNT_MODE_NORMAL] = "normal", > + [COUNTER_COUNT_MODE_RANGE_LIMIT] = "range limit", > + [COUNTER_COUNT_MODE_NON_RECYCLE] = "non-recycle", > + [COUNTER_COUNT_MODE_MODULO_N] = "modulo-n" > +}; > +EXPORT_SYMBOL_GPL(counter_count_mode_str); Dunno. Exporting const tables saying "forward" and "backward". Can we ... somehow make it work without need to export this?
On Tue 2019-04-02 15:30:37, William Breathitt Gray wrote: > This patch adds standard documentation for the userspace sysfs > attributes of the Generic Counter interface. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > Documentation/ABI/testing/sysfs-bus-counter | 230 ++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 231 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-counter > > diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter > new file mode 100644 > index 000000000000..566bd99fe0a5 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-counter > @@ -0,0 +1,230 @@ > +What: /sys/bus/counter/devices/counterX/countY/count > +KernelVersion: 5.2 > +Contact: linux-iio@vger.kernel.org > +Description: > + Count data of Count Y represented as a string. > + > +What: /sys/bus/counter/devices/counterX/countY/ceiling > +KernelVersion: 5.2 > +Contact: linux-iio@vger.kernel.org > +Description: > + Count value ceiling for Count Y. This is the upper limit for the > + respective counter. > + > +What: /sys/bus/counter/devices/counterX/countY/floor > +KernelVersion: 5.2 > +Contact: linux-iio@vger.kernel.org > +Description: > + Count value floor for Count Y. This is the lower limit for the > + respective counter. > + > +What: /sys/bus/counter/devices/counterX/countY/count_mode > +KernelVersion: 5.2 > +Contact: linux-iio@vger.kernel.org > +Description: > + Count mode for channel Y. The ceiling and floor values for > + Count Y are used by the count mode where required. The following > + count modes are available: > + > + normal: > + Counting is continuous in either direction. > + > + range limit: > + An upper or lower limit is set, mimicking limit switches > + in the mechanical counterpart. The upper limit is set to > + the Count Y ceiling value, while the lower limit is set > + to the Count Y floor value. The counter freezes at > + count = ceiling when counting up, and at count = floor > + when counting down. At either of these limits, the > + counting is resumed only when the count direction is > + reversed. > + > + non-recycle: > + The counter is disabled whenever a counter overflow or > + underflow takes place. The counter is re-enabled when a > + new count value is loaded to the counter via a preset > + operation or direct write. > + > + modulo-n: > + A count value boundary is set between the Count Y floor > + value and the Count Y ceiling value. The counter is > + reset to the Count Y floor value at count = ceiling when > + counting up, while the counter is set to the Count Y > + ceiling value at count = floor when counting down; the > + counter does not freeze at the boundary points, but > + counts continuously throughout. > + > +What: /sys/bus/counter/devices/counterX/countY/count_mode_available > +What: /sys/bus/counter/devices/counterX/countY/error_noise_available > +What: /sys/bus/counter/devices/counterX/countY/function_available > +What: /sys/bus/counter/devices/counterX/countY/signalZ_action_available > +KernelVersion: 5.2 > +Contact: linux-iio@vger.kernel.org > +Description: > + Discrete set of available values for the respective Count Y > + configuration are listed in this file. Values are delimited by > + newline characters. Elsewhere in sysfs we do space-separated: pavel@amd:~$ cat /sys/power/state freeze mem disk And we use [] to mark current selection: pavel@amd:~$ cat /sys/class/leds/tpacpi\:\:thinkvantage/trigger [none] bluetooth-power rfkill-any rfkill-none kbd-scrolllock kbd-numlock kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock kbd-ctrlrlock AC-online BAT0-charging-or-full BAT0-charging BAT0-full BAT0-charging-blink-full-solid rfkill0 phy0rx phy0tx phy0assoc phy0radio phy0tpt mmc0 timer heartbeat audio-mute audio-micmute rfkill1 Note this only works if you have less than PAGE_SIZE of entries... and will never have more. Pavel
On Mon, Apr 08, 2019 at 11:55:15PM +0200, Pavel Machek wrote: > Hi! > > > +const char *const counter_count_direction_str[2] = { > > + [COUNTER_COUNT_DIRECTION_FORWARD] = "forward", > > + [COUNTER_COUNT_DIRECTION_BACKWARD] = "backward" > > +}; > > +EXPORT_SYMBOL_GPL(counter_count_direction_str); > > + > > +const char *const counter_count_mode_str[4] = { > > + [COUNTER_COUNT_MODE_NORMAL] = "normal", > > + [COUNTER_COUNT_MODE_RANGE_LIMIT] = "range limit", > > + [COUNTER_COUNT_MODE_NON_RECYCLE] = "non-recycle", > > + [COUNTER_COUNT_MODE_MODULO_N] = "modulo-n" > > +}; > > +EXPORT_SYMBOL_GPL(counter_count_mode_str); > > Dunno. Exporting const tables saying "forward" and "backward". Can we > ... somehow make it work without need to export this? > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html Right now there are only have 4 counter devices supported in this patchset, but it is expected that support for a greater variety of devices will be added. For these future cases, new count directions will be added to match their functionality. For example, suppose support for a rotary encoder device is added. These type of devices do not move forward/backward but rather rotate. In these cases, the following count directions may be added: [COUNTER_COUNT_DIRECTION_CLOCKWISE] = "clockwise", [COUNTER_COUNT_DIRECTION_COUNTERCLOCKWISE] = "counterclockwise" Or as another example, suppose support for a two-axis precision positioning table is added. These devices support positioning in a cartesian coordinate system. In these cases, spatial direction may serve as useful count directions: [COUNTER_COUNT_DIRECTION_NORTH] = "north", [COUNTER_COUNT_DIRECTION_NORTHEAST] = "northeast", [COUNTER_COUNT_DIRECTION_EAST] = "east", [COUNTER_COUNT_DIRECTION_SOUTHEAST] = "southeast", [COUNTER_COUNT_DIRECTION_SOUTH] = "south", [COUNTER_COUNT_DIRECTION_SOUTHWEST] = "southwest", [COUNTER_COUNT_DIRECTION_WEST] = "west", [COUNTER_COUNT_DIRECTION_NORTHWEST] = "northwest" A const table is conveinent in these scenarios because support for new count directions may be easily added by simple entry into the table. William Breathitt Gray
On Mon, Apr 08, 2019 at 11:55:31PM +0200, Pavel Machek wrote: > On Tue 2019-04-02 15:30:37, William Breathitt Gray wrote: > > This patch adds standard documentation for the userspace sysfs > > attributes of the Generic Counter interface. > > > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > --- > > Documentation/ABI/testing/sysfs-bus-counter | 230 ++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 231 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-counter > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter > > new file mode 100644 > > index 000000000000..566bd99fe0a5 > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-bus-counter > > @@ -0,0 +1,230 @@ > > +What: /sys/bus/counter/devices/counterX/countY/count > > +KernelVersion: 5.2 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Count data of Count Y represented as a string. > > + > > +What: /sys/bus/counter/devices/counterX/countY/ceiling > > +KernelVersion: 5.2 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Count value ceiling for Count Y. This is the upper limit for the > > + respective counter. > > + > > +What: /sys/bus/counter/devices/counterX/countY/floor > > +KernelVersion: 5.2 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Count value floor for Count Y. This is the lower limit for the > > + respective counter. > > + > > +What: /sys/bus/counter/devices/counterX/countY/count_mode > > +KernelVersion: 5.2 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Count mode for channel Y. The ceiling and floor values for > > + Count Y are used by the count mode where required. The following > > + count modes are available: > > + > > + normal: > > + Counting is continuous in either direction. > > + > > + range limit: > > + An upper or lower limit is set, mimicking limit switches > > + in the mechanical counterpart. The upper limit is set to > > + the Count Y ceiling value, while the lower limit is set > > + to the Count Y floor value. The counter freezes at > > + count = ceiling when counting up, and at count = floor > > + when counting down. At either of these limits, the > > + counting is resumed only when the count direction is > > + reversed. > > + > > + non-recycle: > > + The counter is disabled whenever a counter overflow or > > + underflow takes place. The counter is re-enabled when a > > + new count value is loaded to the counter via a preset > > + operation or direct write. > > + > > + modulo-n: > > + A count value boundary is set between the Count Y floor > > + value and the Count Y ceiling value. The counter is > > + reset to the Count Y floor value at count = ceiling when > > + counting up, while the counter is set to the Count Y > > + ceiling value at count = floor when counting down; the > > + counter does not freeze at the boundary points, but > > + counts continuously throughout. > > + > > +What: /sys/bus/counter/devices/counterX/countY/count_mode_available > > +What: /sys/bus/counter/devices/counterX/countY/error_noise_available > > +What: /sys/bus/counter/devices/counterX/countY/function_available > > +What: /sys/bus/counter/devices/counterX/countY/signalZ_action_available > > +KernelVersion: 5.2 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Discrete set of available values for the respective Count Y > > + configuration are listed in this file. Values are delimited by > > + newline characters. > > Elsewhere in sysfs we do space-separated: > > pavel@amd:~$ cat /sys/power/state > freeze mem disk > > And we use [] to mark current selection: > > pavel@amd:~$ cat /sys/class/leds/tpacpi\:\:thinkvantage/trigger > [none] bluetooth-power rfkill-any rfkill-none kbd-scrolllock > kbd-numlock kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock > kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock > kbd-ctrlrlock AC-online BAT0-charging-or-full BAT0-charging BAT0-full > BAT0-charging-blink-full-solid rfkill0 phy0rx phy0tx phy0assoc > phy0radio phy0tpt mmc0 timer heartbeat audio-mute audio-micmute > rfkill1 > > Note this only works if you have less than PAGE_SIZE of entries... and > will never have more. > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html Marking the current selection with [] or similar does seem useful. But delimiting by space does seem to cause confusion in cases where the values also include spaces (e.g. "quadrature x1 a"). I see that in these cases a "-" is used in place of a space, but that wouldn't work very well when values can also contain hyphens (e.g. "pulse-direction"). William Breathitt Gray
On 4/8/19 4:55 PM, Pavel Machek wrote: > > pavel@amd:~$ cat /sys/power/state > freeze mem disk > > And we use [] to mark current selection: I know this is used elsewhere, but I don't think it is a good pattern to copy. Parsing it from user-space is annoying. Also it breaks the sysfs rule of "one item per file" since it tells us two things - the list of possible values _and_ the current active value. > > pavel@amd:~$ cat /sys/class/leds/tpacpi\:\:thinkvantage/trigger > [none] bluetooth-power rfkill-any rfkill-none kbd-scrolllock > kbd-numlock kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock > kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock > kbd-ctrlrlock AC-online BAT0-charging-or-full BAT0-charging BAT0-full > BAT0-charging-blink-full-solid rfkill0 phy0rx phy0tx phy0assoc > phy0radio phy0tpt mmc0 timer heartbeat audio-mute audio-micmute > rfkill1 > > Note this only works if you have less than PAGE_SIZE of entries... and > will never have more. > > Pavel >
On Sun, Apr 07, 2019 at 03:25:50PM +0100, Jonathan Cameron wrote: > On Tue, 2 Apr 2019 15:30:35 +0900 > William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > > Changes in v10: > > - Fix minor typographical errors in documentation > > - Merge the FlexTimer Module Quadrature decoder counter driver patches > > > > This revision is functionally identical to the last; changes in this > > version were made to fix minor typos in the documentation files and also > > to pull in the new FTM quadrature decoder counter driver. > > > > The Generic Counter API has been and is still in a feature freeze until > > it is merged into the mainline. The following features will be > > investigated after the merge: interrupt support for counter devices, and > > a character device interface for low-latency applications. > > Hi William / al, > > So the question is how to move this forwards? I'm happy with how it turned > out and the existing drivers we had in IIO are a lot cleaner under > the counter subsystem (other than the backwards compatibility for those that > ever existed in IIO). For those not following closely the situation is: I've now sucked this into my staging-testing branch and if 0-day is fine with it, I'll merge it to staging-next in a day or so. This way you can build on it for any iio drivers that might be coming. I do have reservations about that one sysfs file that is multi-line, and I think it will come to bite you in the end over time, so I reserve the right to say "I told you so" when that happens... But, I don't have a better answer for it now, so don't really worry about it :) thanks, greg k-h
On 02/04/2019 08:30, William Breathitt Gray wrote: > From: Patrick Havelange <patrick.havelange@essensium.com> > > Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of > this file. > Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT. > > Reviewed-by: Esben Haabendal <esben@haabendal.dk> > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Please, do pick my Acked-by from V2. > --- > drivers/clocksource/timer-fsl-ftm.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/clocksource/timer-fsl-ftm.c b/drivers/clocksource/timer-fsl-ftm.c > index 846d18daf893..e1c34b2f53a5 100644 > --- a/drivers/clocksource/timer-fsl-ftm.c > +++ b/drivers/clocksource/timer-fsl-ftm.c > @@ -19,20 +19,9 @@ > #include <linux/of_irq.h> > #include <linux/sched_clock.h> > #include <linux/slab.h> > +#include <linux/fsl/ftm.h> > > -#define FTM_SC 0x00 > -#define FTM_SC_CLK_SHIFT 3 > -#define FTM_SC_CLK_MASK (0x3 << FTM_SC_CLK_SHIFT) > -#define FTM_SC_CLK(c) ((c) << FTM_SC_CLK_SHIFT) > -#define FTM_SC_PS_MASK 0x7 > -#define FTM_SC_TOIE BIT(6) > -#define FTM_SC_TOF BIT(7) > - > -#define FTM_CNT 0x04 > -#define FTM_MOD 0x08 > -#define FTM_CNTIN 0x4C > - > -#define FTM_PS_MAX 7 > +#define FTM_SC_CLK(c) ((c) << FTM_SC_CLK_MASK_SHIFT) > > struct ftm_clock_device { > void __iomem *clksrc_base; >
On Thu, 25 Apr 2019 21:36:24 +0200 Greg KH <gregkh@linuxfoundation.org> wrote: > On Sun, Apr 07, 2019 at 03:25:50PM +0100, Jonathan Cameron wrote: > > On Tue, 2 Apr 2019 15:30:35 +0900 > > William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > > > > Changes in v10: > > > - Fix minor typographical errors in documentation > > > - Merge the FlexTimer Module Quadrature decoder counter driver patches > > > > > > This revision is functionally identical to the last; changes in this > > > version were made to fix minor typos in the documentation files and also > > > to pull in the new FTM quadrature decoder counter driver. > > > > > > The Generic Counter API has been and is still in a feature freeze until > > > it is merged into the mainline. The following features will be > > > investigated after the merge: interrupt support for counter devices, and > > > a character device interface for low-latency applications. > > > > Hi William / al, > > > > So the question is how to move this forwards? I'm happy with how it turned > > out and the existing drivers we had in IIO are a lot cleaner under > > the counter subsystem (other than the backwards compatibility for those that > > ever existed in IIO). For those not following closely the situation is: > > I've now sucked this into my staging-testing branch and if 0-day is fine > with it, I'll merge it to staging-next in a day or so. This way you can > build on it for any iio drivers that might be coming. Great thanks. > > I do have reservations about that one sysfs file that is multi-line, and > I think it will come to bite you in the end over time, so I reserve the > right to say "I told you so" when that happens... > > But, I don't have a better answer for it now, so don't really worry > about it :) > > thanks, > > greg k-h Looks like a few late breaking comments came in, but nothing that can't be fixed up before this reaches a release. Thanks, Jonathan
Changes in v10: - Fix minor typographical errors in documentation - Merge the FlexTimer Module Quadrature decoder counter driver patches This revision is functionally identical to the last; changes in this version were made to fix minor typos in the documentation files and also to pull in the new FTM quadrature decoder counter driver. The Generic Counter API has been and is still in a feature freeze until it is merged into the mainline. The following features will be investigated after the merge: interrupt support for counter devices, and a character device interface for low-latency applications. Benjamin Gaignard (2): counter: Add STM32 Timer quadrature encoder dt-bindings: counter: Document stm32 quadrature encoder Fabrice Gasnier (2): counter: stm32-lptimer: add counter device dt-bindings: counter: Adjust dt-bindings for STM32 lptimer move Patrick Havelange (7): include/fsl: add common FlexTimer #defines in a separate header. drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #defines drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines dt-bindings: counter: ftm-quaddec counter: add FlexTimer Module Quadrature decoder counter driver counter: ftm-quaddec: Documentation: Add specific counter sysfs documentation LS1021A: dtsi: add ftm quad decoder entries William Breathitt Gray (7): counter: Introduce the Generic Counter interface counter: Documentation: Add Generic Counter sysfs documentation docs: Add Generic Counter interface documentation iio: 104-quad-8: Update license boilerplate counter: 104-quad-8: Add Generic Counter interface support counter: 104-quad-8: Documentation: Add Generic Counter sysfs documentation iio: counter: Add deprecation markings for IIO Counter attributes Documentation/ABI/testing/sysfs-bus-counter | 230 +++ .../ABI/testing/sysfs-bus-counter-104-quad-8 | 36 + .../ABI/testing/sysfs-bus-counter-ftm-quaddec | 16 + Documentation/ABI/testing/sysfs-bus-iio | 8 + .../testing/sysfs-bus-iio-counter-104-quad-8 | 16 + .../bindings/counter/ftm-quaddec.txt | 18 + .../{iio => }/counter/stm32-lptimer-cnt.txt | 0 .../bindings/counter/stm32-timer-cnt.txt | 31 + .../devicetree/bindings/mfd/stm32-lptimer.txt | 2 +- .../devicetree/bindings/mfd/stm32-timers.txt | 7 + Documentation/driver-api/generic-counter.rst | 342 ++++ Documentation/driver-api/index.rst | 1 + MAINTAINERS | 15 +- arch/arm/boot/dts/ls1021a.dtsi | 28 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/clocksource/timer-fsl-ftm.c | 15 +- drivers/{iio => }/counter/104-quad-8.c | 782 +++++++- drivers/counter/Kconfig | 60 + drivers/counter/Makefile | 10 + drivers/counter/counter.c | 1567 +++++++++++++++++ drivers/counter/ftm-quaddec.c | 356 ++++ drivers/{iio => }/counter/stm32-lptimer-cnt.c | 361 +++- drivers/counter/stm32-timer-cnt.c | 390 ++++ drivers/iio/Kconfig | 1 - drivers/iio/Makefile | 1 - drivers/iio/counter/Kconfig | 34 - drivers/iio/counter/Makefile | 8 - drivers/pwm/pwm-fsl-ftm.c | 44 +- include/linux/counter.h | 510 ++++++ include/linux/counter_enum.h | 45 + include/linux/fsl/ftm.h | 88 + 32 files changed, 4877 insertions(+), 148 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-counter create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-104-quad-8 create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-ftm-quaddec create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt rename Documentation/devicetree/bindings/{iio => }/counter/stm32-lptimer-cnt.txt (100%) create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt create mode 100644 Documentation/driver-api/generic-counter.rst rename drivers/{iio => }/counter/104-quad-8.c (44%) create mode 100644 drivers/counter/Kconfig create mode 100644 drivers/counter/Makefile create mode 100644 drivers/counter/counter.c create mode 100644 drivers/counter/ftm-quaddec.c rename drivers/{iio => }/counter/stm32-lptimer-cnt.c (51%) create mode 100644 drivers/counter/stm32-timer-cnt.c delete mode 100644 drivers/iio/counter/Kconfig delete mode 100644 drivers/iio/counter/Makefile create mode 100644 include/linux/counter.h create mode 100644 include/linux/counter_enum.h create mode 100644 include/linux/fsl/ftm.h