| Message ID | 20190411172807.57796-1-sboyd@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | platform/x86: pmc_atom: Drop __initconst on dmi table | expand |
Hi Stephen, On 11-04-19 19:28, Stephen Boyd wrote: > It's used by probe and that isn't an init function. Drop this so that we > don't get a section mismatch. > > Reported-by: kbuild test robot <lkp@intel.com> > Cc: David Müller <dave.mueller@gmx.ch> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical") > Signed-off-by: Stephen Boyd <sboyd@kernel.org> Thank you for fixing this, I agree that this is the correct fix: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/pmc_atom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c > index eaec2d306481..c7039f52ad51 100644 > --- a/drivers/platform/x86/pmc_atom.c > +++ b/drivers/platform/x86/pmc_atom.c > @@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc) > * Some systems need one or more of their pmc_plt_clks to be > * marked as critical. > */ > -static const struct dmi_system_id critclk_systems[] __initconst = { > +static const struct dmi_system_id critclk_systems[] = { > { > .ident = "MPL CEC1x", > .matches = { >
diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c index eaec2d306481..c7039f52ad51 100644 --- a/drivers/platform/x86/pmc_atom.c +++ b/drivers/platform/x86/pmc_atom.c @@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc) * Some systems need one or more of their pmc_plt_clks to be * marked as critical. */ -static const struct dmi_system_id critclk_systems[] __initconst = { +static const struct dmi_system_id critclk_systems[] = { { .ident = "MPL CEC1x", .matches = {
It's used by probe and that isn't an init function. Drop this so that we don't get a section mismatch. Reported-by: kbuild test robot <lkp@intel.com> Cc: David Müller <dave.mueller@gmx.ch> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical") Signed-off-by: Stephen Boyd <sboyd@kernel.org> --- drivers/platform/x86/pmc_atom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)