Message ID | 20190410232543.13297-1-peron.clem@gmail.com |
---|---|
Headers | show |
Series | Add Allwinner H6 Mali Midgard gpu node | expand |
On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > Add the mali gpu node to the H6 device-tree. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 ++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > index e0dc4a05c1ba..152b2128aadf 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -17,6 +17,71 @@ > #address-cells = <1>; > #size-cells = <1>; > > + gpu_opp_table: opp_table1 { > + compatible = "operating-points-v2"; > + > + opp@756000000 { > + opp-hz = /bits/ 64 <756000000>; > + opp-microvolt = <1040000>; > + }; > + opp@624000000 { > + opp-hz = /bits/ 64 <624000000>; > + opp-microvolt = <950000>; > + }; > + opp@576000000 { > + opp-hz = /bits/ 64 <576000000>; > + opp-microvolt = <930000>; > + }; > + opp@540000000 { > + opp-hz = /bits/ 64 <540000000>; > + opp-microvolt = <910000>; > + }; > + opp@504000000 { > + opp-hz = /bits/ 64 <504000000>; > + opp-microvolt = <890000>; > + }; > + opp@456000000 { > + opp-hz = /bits/ 64 <456000000>; > + opp-microvolt = <870000>; > + }; > + opp@432000000 { > + opp-hz = /bits/ 64 <432000000>; > + opp-microvolt = <860000>; > + }; > + opp@420000000 { > + opp-hz = /bits/ 64 <420000000>; > + opp-microvolt = <850000>; > + }; > + opp@408000000 { > + opp-hz = /bits/ 64 <408000000>; > + opp-microvolt = <840000>; > + }; > + opp@384000000 { > + opp-hz = /bits/ 64 <384000000>; > + opp-microvolt = <830000>; > + }; > + opp@360000000 { > + opp-hz = /bits/ 64 <360000000>; > + opp-microvolt = <820000>; > + }; > + opp@336000000 { > + opp-hz = /bits/ 64 <336000000>; > + opp-microvolt = <810000>; > + }; > + opp@312000000 { > + opp-hz = /bits/ 64 <312000000>; > + opp-microvolt = <810000>; > + }; > + opp@264000000 { > + opp-hz = /bits/ 64 <264000000>; > + opp-microvolt = <810000>; > + }; > + opp@216000000 { > + opp-hz = /bits/ 64 <216000000>; > + opp-microvolt = <810000>; > + }; > + }; > + How were those OPPs tested? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi, On Thu, 11 Apr 2019 at 09:28, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > > Add the mali gpu node to the H6 device-tree. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 ++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index e0dc4a05c1ba..152b2128aadf 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -17,6 +17,71 @@ > > #address-cells = <1>; > > #size-cells = <1>; > > > > + gpu_opp_table: opp_table1 { > > + compatible = "operating-points-v2"; > > + > > + opp@756000000 { > > + opp-hz = /bits/ 64 <756000000>; > > + opp-microvolt = <1040000>; > > + }; > > + opp@624000000 { > > + opp-hz = /bits/ 64 <624000000>; > > + opp-microvolt = <950000>; > > + }; > > + opp@576000000 { > > + opp-hz = /bits/ 64 <576000000>; > > + opp-microvolt = <930000>; > > + }; > > + opp@540000000 { > > + opp-hz = /bits/ 64 <540000000>; > > + opp-microvolt = <910000>; > > + }; > > + opp@504000000 { > > + opp-hz = /bits/ 64 <504000000>; > > + opp-microvolt = <890000>; > > + }; > > + opp@456000000 { > > + opp-hz = /bits/ 64 <456000000>; > > + opp-microvolt = <870000>; > > + }; > > + opp@432000000 { > > + opp-hz = /bits/ 64 <432000000>; > > + opp-microvolt = <860000>; > > + }; > > + opp@420000000 { > > + opp-hz = /bits/ 64 <420000000>; > > + opp-microvolt = <850000>; > > + }; > > + opp@408000000 { > > + opp-hz = /bits/ 64 <408000000>; > > + opp-microvolt = <840000>; > > + }; > > + opp@384000000 { > > + opp-hz = /bits/ 64 <384000000>; > > + opp-microvolt = <830000>; > > + }; > > + opp@360000000 { > > + opp-hz = /bits/ 64 <360000000>; > > + opp-microvolt = <820000>; > > + }; > > + opp@336000000 { > > + opp-hz = /bits/ 64 <336000000>; > > + opp-microvolt = <810000>; > > + }; > > + opp@312000000 { > > + opp-hz = /bits/ 64 <312000000>; > > + opp-microvolt = <810000>; > > + }; > > + opp@264000000 { > > + opp-hz = /bits/ 64 <264000000>; > > + opp-microvolt = <810000>; > > + }; > > + opp@216000000 { > > + opp-hz = /bits/ 64 <216000000>; > > + opp-microvolt = <810000>; > > + }; > > + }; > > + > > How were those OPPs tested? They are taken from the vendor device tree. https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L2121 Clement > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Thu, Apr 11, 2019 at 09:56:15AM +0200, Clément Péron wrote: > Hi, > > On Thu, 11 Apr 2019 at 09:28, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > > > Add the mali gpu node to the H6 device-tree. > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > --- > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 ++++++++++++++++++++ > > > 1 file changed, 80 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > index e0dc4a05c1ba..152b2128aadf 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -17,6 +17,71 @@ > > > #address-cells = <1>; > > > #size-cells = <1>; > > > > > > + gpu_opp_table: opp_table1 { > > > + compatible = "operating-points-v2"; > > > + > > > + opp@756000000 { > > > + opp-hz = /bits/ 64 <756000000>; > > > + opp-microvolt = <1040000>; > > > + }; > > > + opp@624000000 { > > > + opp-hz = /bits/ 64 <624000000>; > > > + opp-microvolt = <950000>; > > > + }; > > > + opp@576000000 { > > > + opp-hz = /bits/ 64 <576000000>; > > > + opp-microvolt = <930000>; > > > + }; > > > + opp@540000000 { > > > + opp-hz = /bits/ 64 <540000000>; > > > + opp-microvolt = <910000>; > > > + }; > > > + opp@504000000 { > > > + opp-hz = /bits/ 64 <504000000>; > > > + opp-microvolt = <890000>; > > > + }; > > > + opp@456000000 { > > > + opp-hz = /bits/ 64 <456000000>; > > > + opp-microvolt = <870000>; > > > + }; > > > + opp@432000000 { > > > + opp-hz = /bits/ 64 <432000000>; > > > + opp-microvolt = <860000>; > > > + }; > > > + opp@420000000 { > > > + opp-hz = /bits/ 64 <420000000>; > > > + opp-microvolt = <850000>; > > > + }; > > > + opp@408000000 { > > > + opp-hz = /bits/ 64 <408000000>; > > > + opp-microvolt = <840000>; > > > + }; > > > + opp@384000000 { > > > + opp-hz = /bits/ 64 <384000000>; > > > + opp-microvolt = <830000>; > > > + }; > > > + opp@360000000 { > > > + opp-hz = /bits/ 64 <360000000>; > > > + opp-microvolt = <820000>; > > > + }; > > > + opp@336000000 { > > > + opp-hz = /bits/ 64 <336000000>; > > > + opp-microvolt = <810000>; > > > + }; > > > + opp@312000000 { > > > + opp-hz = /bits/ 64 <312000000>; > > > + opp-microvolt = <810000>; > > > + }; > > > + opp@264000000 { > > > + opp-hz = /bits/ 64 <264000000>; > > > + opp-microvolt = <810000>; > > > + }; > > > + opp@216000000 { > > > + opp-hz = /bits/ 64 <216000000>; > > > + opp-microvolt = <810000>; > > > + }; > > > + }; > > > + > > > > How were those OPPs tested? > > They are taken from the vendor device tree. > https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L2121 Please remove them if you haven't tested them then. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com