mbox series

[net,v2,0/2] Fix thunderx MTU with XDP

Message ID 20190408210647.7385-1-mcroce@redhat.com
Headers show
Series Fix thunderx MTU with XDP | expand

Message

Matteo Croce April 8, 2019, 9:06 p.m. UTC 
The thunderx driver can't use XDP with all MTU values.
This patches sets the right MTU values, and add a check to avoid setting
a wrong value which will not function.

Matteo Croce (2):
  net: thunderx: raise XDP MTU to 1508
  net: thunderx: don't allow jumbo frames with XDP

 .../net/ethernet/cavium/thunder/nicvf_main.c  | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

Comments

David Miller April 11, 2019, 2:35 a.m. UTC | #1 
From: Matteo Croce <mcroce@redhat.com>
Date: Mon,  8 Apr 2019 23:06:45 +0200

> The thunderx driver can't use XDP with all MTU values.
> This patches sets the right MTU values, and add a check to avoid setting
> a wrong value which will not function.

Series applied and queued up for -stable.
David Miller April 11, 2019, 2:35 a.m. UTC | #2 
From: David Miller <davem@davemloft.net>
Date: Wed, 10 Apr 2019 19:35:16 -0700 (PDT)

> From: Matteo Croce <mcroce@redhat.com>
> Date: Mon,  8 Apr 2019 23:06:45 +0200
> 
>> The thunderx driver can't use XDP with all MTU values.
>> This patches sets the right MTU values, and add a check to avoid setting
>> a wrong value which will not function.
> 
> Series applied and queued up for -stable.

Actually, reverted, -ENOCOMPILE:

drivers/net/ethernet/cavium/thunder/nicvf_main.c: In function ‘nicvf_change_mtu’:
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: error: ‘dev’ undeclared (first use in this function); did you mean ‘cdev’?
   netdev_warn(dev, "Jumbo frames not yet supported with XDP, current MTU %d.\n",
               ^~~
               cdev
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: note: each undeclared identifier is reported only once for each function it appears in