mbox series

[0/2] arm64: dts: add fsl-dpaa2-console node

Message ID 1553628194-25119-1-git-send-email-ioana.ciornei@nxp.com
Headers show
Series arm64: dts: add fsl-dpaa2-console node | expand

Message

Ioana Ciornei March 26, 2019, 7:23 p.m. UTC 
This patch set adds the fsl-dpaa2-console device tree node for DPAA2 based
platforms and adds its corresponding documentation.

Ioana Ciornei (2):
  arm64: dts: add fsl-dpaa2-console node for DPAA2 platforms
  Documentation: DT: Add entry for DPAA2 console

 Documentation/devicetree/bindings/misc/fsl,dpaa2-console.txt | 11 +++++++++++
 MAINTAINERS                                                  |  1 +
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi               |  5 +++++
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi               |  5 +++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi               |  5 +++++
 5 files changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/fsl,dpaa2-console.txt

Comments

Shawn Guo April 11, 2019, 2:05 a.m. UTC | #1 
On Tue, Mar 26, 2019 at 07:23:29PM +0000, Ioana Ciornei wrote:
> Add the fsl-dpaa2-console device tree node for the following
> DPAA2 based platforms: LS1088A, LS2080A, LS2088A and LX2160A.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 5 +++++
>  3 files changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index de93b42b1f51..5eee5db3ed6c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -571,6 +571,11 @@
>  			clock-names = "apb_pclk", "wdog_clk";
>  		};
>  
> +		fsl-dpaa2-console@0x08340020 {

The node name should be generic, 'console' maybe?  Also, the
unit-address shouldn't have 0x and leading zeros.

Shawn

> +			compatible = "fsl,dpaa2-console";
> +			reg = <0x00000000 0x08340020 0 0x2>;
> +		};
> +
>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,	 /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 6d6ca166f86b..f1521e6d8da0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -321,6 +321,11 @@
>  			};
>  		};
>  
> +		fsl-dpaa2-console@0x08340020 {
> +			compatible = "fsl,dpaa2-console";
> +			reg = <0x00000000 0x08340020 0 0x2>;
> +		};
> +
>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,	 /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 660e78e46268..8febaa517913 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -777,6 +777,11 @@
>  			dma-coherent;
>  		};
>  
> +		fsl-dpaa2-console@0x08340020 {
> +			compatible = "fsl,dpaa2-console";
> +			reg = <0x00000000 0x08340020 0 0x2>;
> +		};
> +
>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,
> -- 
> 1.9.1
>