| Message ID | 20190403075208.30000-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] ehea: remove set but not used variables 'epa' and 'cq_handle_ref' | expand |
On 4/3/2019 1:22 PM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/ibm/ehea/ehea_qmr.c: In function 'ehea_create_cq': > drivers/net/ethernet/ibm/ehea/ehea_qmr.c:127:7: warning: variable 'cq_handle_ref' set but not used [-Wunused-but-set-variable] > drivers/net/ethernet/ibm/ehea/ehea_qmr.c:126:15: warning: variable 'epa' set but not used [-Wunused-but-set-variable] > > They are never used since commit > 7a291083225a ("[PATCH] ehea: IBM eHEA Ethernet Device Driver") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/net/ethernet/ibm/ehea/ehea_qmr.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c > index 5e4e371..77ce173 100644 > --- a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c > +++ b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c > @@ -123,8 +123,7 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, > int nr_of_cqe, u64 eq_handle, u32 cq_token) > { > struct ehea_cq *cq; > - struct h_epa epa; > - u64 *cq_handle_ref, hret, rpage; > + u64 hret, rpage; > u32 counter; > int ret; > void *vpage; > @@ -139,8 +138,6 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, > > cq->adapter = adapter; > > - cq_handle_ref = &cq->fw_handle; > - > hret = ehea_h_alloc_resource_cq(adapter->handle, &cq->attr, > &cq->fw_handle, &cq->epas); > if (hret != H_SUCCESS) { > @@ -188,7 +185,6 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, > } > > hw_qeit_reset(&cq->hw_queue); > - epa = cq->epas.kernel; > ehea_reset_cq_ep(cq); > ehea_reset_cq_n1(cq); >
From: Yue Haibing <yuehaibing@huawei.com> Date: Wed, 3 Apr 2019 15:52:08 +0800 > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/ibm/ehea/ehea_qmr.c: In function 'ehea_create_cq': > drivers/net/ethernet/ibm/ehea/ehea_qmr.c:127:7: warning: variable 'cq_handle_ref' set but not used [-Wunused-but-set-variable] > drivers/net/ethernet/ibm/ehea/ehea_qmr.c:126:15: warning: variable 'epa' set but not used [-Wunused-but-set-variable] > > They are never used since commit > 7a291083225a ("[PATCH] ehea: IBM eHEA Ethernet Device Driver") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c index 5e4e371..77ce173 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c @@ -123,8 +123,7 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, int nr_of_cqe, u64 eq_handle, u32 cq_token) { struct ehea_cq *cq; - struct h_epa epa; - u64 *cq_handle_ref, hret, rpage; + u64 hret, rpage; u32 counter; int ret; void *vpage; @@ -139,8 +138,6 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, cq->adapter = adapter; - cq_handle_ref = &cq->fw_handle; - hret = ehea_h_alloc_resource_cq(adapter->handle, &cq->attr, &cq->fw_handle, &cq->epas); if (hret != H_SUCCESS) { @@ -188,7 +185,6 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter, } hw_qeit_reset(&cq->hw_queue); - epa = cq->epas.kernel; ehea_reset_cq_ep(cq); ehea_reset_cq_n1(cq);