Message ID | 20190402154514.11284-1-tiny.windzz@gmail.com |
---|---|
Headers | show |
Series | nvmem: sunxi-sid: add SID controller support for H6 | expand |
On 02/04/2019 16:45, Yangtao Li wrote: > Because there was an endianness issue. It seems that reg_read > function which the nvmem the driver currently exposes is wrong. > So add the new read function, the new function is used when the > native_endian flag is set. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> This patch and 5/5 does not apply cleanly on nvmem-next. Also I would need an ack from Maxime to be able to apply it. thanks, srini
On 02/04/2019 16:45, Yangtao Li wrote: > Add SID support for H6, and do some cleanup. > For endianness issue, add a new ref_read func. > > Yangtao Li (5): > nvmem: sunxi-sid: fix wrong description in kernel doc > nvmem: sunxi-sid: add binding for H6's SID controller > nvmem: sunxi-sid: convert to SPDX license tags Applied first 3 patches, please resend last two patches after rebase on top of next. Thanks, srini
On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > On 02/04/2019 16:45, Yangtao Li wrote: > > Because there was an endianness issue. It seems that reg_read > > function which the nvmem the driver currently exposes is wrong. > > So add the new read function, the new function is used when the > > native_endian flag is set. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > This patch and 5/5 does not apply cleanly on nvmem-next. > Also I would need an ack from Maxime to be able to apply it. Chen-Yu has mostly been taking care of this recently, so I'd like his feedback on this. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Thu, Apr 4, 2019 at 7:05 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > > > > On 02/04/2019 16:45, Yangtao Li wrote: > > > Because there was an endianness issue. It seems that reg_read > > > function which the nvmem the driver currently exposes is wrong. > > > So add the new read function, the new function is used when the > > > native_endian flag is set. > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > > This patch and 5/5 does not apply cleanly on nvmem-next. > > Also I would need an ack from Maxime to be able to apply it. > > Chen-Yu has mostly been taking care of this recently, so I'd like his > feedback on this. As you previously requested, my patches already switch everything to native endianess. There's no need to differentiate between the old and the new now. So this patch and the native_endian flag is not needed. ChenYu