Message ID | 20190320141425.20920-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers | show |
Series | [-next] pinctrl: fsl: Make pinctrl_ipc_handle static | expand |
On 3/20/2019 7:44 PM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning: > symbol 'pinctrl_ipc_handle' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pinctrl/freescale/pinctrl-scu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c > index 83e69c0..73bf1d9 100644 > --- a/drivers/pinctrl/freescale/pinctrl-scu.c > +++ b/drivers/pinctrl/freescale/pinctrl-scu.c > @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get { > u32 val; > } __packed; > > -struct imx_sc_ipc *pinctrl_ipc_handle; > +static struct imx_sc_ipc *pinctrl_ipc_handle; > > int imx_pinctrl_sc_ipc_init(struct platform_device *pdev) > { Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
On Wed, Mar 20, 2019 at 9:15 PM Yue Haibing <yuehaibing@huawei.com> wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning: > symbol 'pinctrl_ipc_handle' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c index 83e69c0..73bf1d9 100644 --- a/drivers/pinctrl/freescale/pinctrl-scu.c +++ b/drivers/pinctrl/freescale/pinctrl-scu.c @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get { u32 val; } __packed; -struct imx_sc_ipc *pinctrl_ipc_handle; +static struct imx_sc_ipc *pinctrl_ipc_handle; int imx_pinctrl_sc_ipc_init(struct platform_device *pdev) {