| Message ID | 1554328676-10715-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf,1/2] ixgbe: fix AF_XDP tx byte count | expand |
[ +Jeff ] Given these two are contained to ixgbe, I presume Jeff wants to pick these up instead via his tree? On 04/03/2019 11:57 PM, William Tu wrote: > The tx bytecount is done twice. When running > './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' > The avg packet size is 120 instead of 60. So remove the > extra one. > > Signed-off-by: William Tu <u9012063@gmail.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c > index bfe95ce0bd7f..71b8474a9b4c 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c > @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, > xsk_frames++; > > tx_bi->xdpf = NULL; > - total_bytes += tx_bi->bytecount; > > tx_bi++; > tx_desc++; >
> On Apr 3, 2019, at 17:13, Daniel Borkmann <daniel@iogearbox.net> wrote: > > [ +Jeff ] > > Given these two are contained to ixgbe, I presume Jeff wants to pick > these up instead via his tree? Yes, I will be picking them up. > >> On 04/03/2019 11:57 PM, William Tu wrote: >> The tx bytecount is done twice. When running >> './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' >> The avg packet size is 120 instead of 60. So remove the >> extra one. >> >> Signed-off-by: William Tu <u9012063@gmail.com> >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> index bfe95ce0bd7f..71b8474a9b4c 100644 >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, >> xsk_frames++; >> >> tx_bi->xdpf = NULL; >> - total_bytes += tx_bi->bytecount; >> >> tx_bi++; >> tx_desc++; >> >
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c index bfe95ce0bd7f..71b8474a9b4c 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, xsk_frames++; tx_bi->xdpf = NULL; - total_bytes += tx_bi->bytecount; tx_bi++; tx_desc++;
The tx bytecount is done twice. When running './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' The avg packet size is 120 instead of 60. So remove the extra one. Signed-off-by: William Tu <u9012063@gmail.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 - 1 file changed, 1 deletion(-)