mbox series

[bpf,0/2] fix btf_dedup()'s type graph equivalence check

Message ID 20190327050007.2419746-1-andrii.nakryiko@gmail.com
Headers show
Series fix btf_dedup()'s type graph equivalence check | expand

Message

Andrii Nakryiko March 27, 2019, 5 a.m. UTC
From: Andrii Nakryiko <andriin@fb.com>

This patch set fixes bug in btf_dedup_is_equiv() check mishandling equivalence
comparison between VOID kind in candidate type graph versus anonymous non-VOID
kind in canonical type graph.

Patch #1 fixes bug, by comparing candidate and canonical kinds for equality,
before proceeding to kind-specific checks.
Patch #2 adds a test case testing this specific scenario.

Andrii Nakryiko (2):
  libbpf: fix btf_dedup equivalence check handling of different kinds
  selftests/bpf: add btf_dedup test for VOID equivalence check

 tools/lib/bpf/btf.c                    |  3 ++
 tools/testing/selftests/bpf/test_btf.c | 47 ++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)

Comments

Alexei Starovoitov March 27, 2019, 3:04 p.m. UTC | #1
On Tue, Mar 26, 2019 at 10:00 PM <andrii.nakryiko@gmail.com> wrote:
>
> From: Andrii Nakryiko <andriin@fb.com>
>
> This patch set fixes bug in btf_dedup_is_equiv() check mishandling equivalence
> comparison between VOID kind in candidate type graph versus anonymous non-VOID
> kind in canonical type graph.
>
> Patch #1 fixes bug, by comparing candidate and canonical kinds for equality,
> before proceeding to kind-specific checks.
> Patch #2 adds a test case testing this specific scenario.

Applied. Thanks