mbox series

[net,0/2] thunderx: fix receive buffer page recycling

Message ID 155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan
Headers show
Series thunderx: fix receive buffer page recycling | expand

Message

Dean Nelson March 26, 2019, 2:04 p.m. UTC 
In attempting to optimize receive buffer page recycling for XDP, commit
773225388dae15e72790 inadvertently introduced two problems for the non-XDP
case, that will be addressed by this patch series.

Dean Nelson (2):
  thunderx: enable page recycling for non-XDP case
  thunderx: eliminate extra calls to put_page() for pages held for recycling

 drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

Comments

Dean Nelson March 26, 2019, 3:39 p.m. UTC | #1 
On 3/26/19 9:04 AM, Dean Nelson wrote:
> In attempting to optimize receive buffer page recycling for XDP, commit
> 773225388dae15e72790 inadvertently introduced two problems for the non-XDP
> case, that will be addressed by this patch series.
> 
> Dean Nelson (2):
>    thunderx: enable page recycling for non-XDP case
>    thunderx: eliminate extra calls to put_page() for pages held for recycling
> 
>   drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
>   1 file changed, 14 insertions(+), 16 deletions(-)
> 
I'm self-NACK'ng this patchset in order to add the omitted 'Fixes' lines.