mbox series

[0/2] appletalk: A cleanup and bugfix

Message ID 20190228135627.30408-1-yuehaibing@huawei.com
Headers show
Series appletalk: A cleanup and bugfix | expand

Message

Yue Haibing Feb. 28, 2019, 1:56 p.m. UTC
From: YueHaibing <yuehaibing@huawei.com>


YueHaibing (2):
  appletalk: use remove_proc_subtree to simplify procfs code
  appletalk: Fix use-after-free in atalk_proc_exit

 include/linux/atalk.h            |  2 +-
 net/appletalk/atalk_proc.c       | 58 +++++++++++++---------------------------
 net/appletalk/ddp.c              | 37 ++++++++++++++++++++-----
 net/appletalk/sysctl_net_atalk.c |  5 +++-
 4 files changed, 54 insertions(+), 48 deletions(-)

Comments

David Miller Feb. 28, 2019, 8:44 p.m. UTC | #1
This series mixes cleanups with a bug fix.

The cleanup is only appropriate for net-next, and the bug fix is
appropriate for net.

Also, your header posting here was empty.  It must actually
say something.

Specifically it must always say what the patch series is doing,
why it is doing it, and why it is doing it that way.

Thanks.
Yue Haibing March 1, 2019, 2:39 a.m. UTC | #2
On 2019/3/1 4:44, David Miller wrote:
> 
> This series mixes cleanups with a bug fix.
> 
> The cleanup is only appropriate for net-next, and the bug fix is
> appropriate for net.

patch 2 is based on patch 1 now, atalk_proc_exit context is changed,
if they go separately, a small conflict will occur while merging

> Also, your header posting here was empty.  It must actually
> say something.
> 
> Specifically it must always say what the patch series is doing,
> why it is doing it, and why it is doing it that way.
> 

Got it, Thanks!

> Thanks.
> 
> .
>