| Message ID | 20190227224642.1069138-3-andriin@fb.com |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | btf_dedup algorithm and test fixes | expand |
On Wed, Feb 27, 2019 at 2:47 PM Andrii Nakryiko <andriin@fb.com> wrote: > > Fix invalid formatting of pointer arg. > > Fixes: ae4ab4b4117d ("btf: expose API to work with raw btf_ext data") > Signed-off-by: Andrii Nakryiko <andriin@fb.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > tools/lib/bpf/btf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h > index 94bbc249b0f1..b60bb7cf5fff 100644 > --- a/tools/lib/bpf/btf.h > +++ b/tools/lib/bpf/btf.h > @@ -76,7 +76,7 @@ LIBBPF_API int btf__get_map_kv_tids(const struct btf *btf, const char *map_name, > > LIBBPF_API struct btf_ext *btf_ext__new(__u8 *data, __u32 size); > LIBBPF_API void btf_ext__free(struct btf_ext *btf_ext); > -LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext* btf_ext, > +LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext *btf_ext, > __u32 *size); > LIBBPF_API int btf_ext__reloc_func_info(const struct btf *btf, > const struct btf_ext *btf_ext, > -- > 2.17.1 >
Em Wed, Feb 27, 2019 at 02:46:38PM -0800, Andrii Nakryiko escreveu: > Fix invalid formatting of pointer arg. > > Fixes: ae4ab4b4117d ("btf: expose API to work with raw btf_ext data") Also I think Fixes here is not applicable :-) - Arnaldo > Signed-off-by: Andrii Nakryiko <andriin@fb.com> > --- > tools/lib/bpf/btf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h > index 94bbc249b0f1..b60bb7cf5fff 100644 > --- a/tools/lib/bpf/btf.h > +++ b/tools/lib/bpf/btf.h > @@ -76,7 +76,7 @@ LIBBPF_API int btf__get_map_kv_tids(const struct btf *btf, const char *map_name, > > LIBBPF_API struct btf_ext *btf_ext__new(__u8 *data, __u32 size); > LIBBPF_API void btf_ext__free(struct btf_ext *btf_ext); > -LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext* btf_ext, > +LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext *btf_ext, > __u32 *size); > LIBBPF_API int btf_ext__reloc_func_info(const struct btf *btf, > const struct btf_ext *btf_ext, > -- > 2.17.1
On Thu, Feb 28, 2019 at 10:53 AM Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > > Em Wed, Feb 27, 2019 at 02:46:38PM -0800, Andrii Nakryiko escreveu: > > Fix invalid formatting of pointer arg. > > > > Fixes: ae4ab4b4117d ("btf: expose API to work with raw btf_ext data") > > Also I think Fixes here is not applicable :-) Yeah, I was probably too pedantic, I'll remove it from v2 :) > > - Arnaldo > > > Signed-off-by: Andrii Nakryiko <andriin@fb.com> > > --- > > tools/lib/bpf/btf.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h > > index 94bbc249b0f1..b60bb7cf5fff 100644 > > --- a/tools/lib/bpf/btf.h > > +++ b/tools/lib/bpf/btf.h > > @@ -76,7 +76,7 @@ LIBBPF_API int btf__get_map_kv_tids(const struct btf *btf, const char *map_name, > > > > LIBBPF_API struct btf_ext *btf_ext__new(__u8 *data, __u32 size); > > LIBBPF_API void btf_ext__free(struct btf_ext *btf_ext); > > -LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext* btf_ext, > > +LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext *btf_ext, > > __u32 *size); > > LIBBPF_API int btf_ext__reloc_func_info(const struct btf *btf, > > const struct btf_ext *btf_ext, > > -- > > 2.17.1 > > -- > > - Arnaldo
diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h index 94bbc249b0f1..b60bb7cf5fff 100644 --- a/tools/lib/bpf/btf.h +++ b/tools/lib/bpf/btf.h @@ -76,7 +76,7 @@ LIBBPF_API int btf__get_map_kv_tids(const struct btf *btf, const char *map_name, LIBBPF_API struct btf_ext *btf_ext__new(__u8 *data, __u32 size); LIBBPF_API void btf_ext__free(struct btf_ext *btf_ext); -LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext* btf_ext, +LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext *btf_ext, __u32 *size); LIBBPF_API int btf_ext__reloc_func_info(const struct btf *btf, const struct btf_ext *btf_ext,
Fix invalid formatting of pointer arg. Fixes: ae4ab4b4117d ("btf: expose API to work with raw btf_ext data") Signed-off-by: Andrii Nakryiko <andriin@fb.com> --- tools/lib/bpf/btf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)