mbox series

[v4,iproute2-next,00/11] Add support for devlink health

Message ID 1551355984-15752-1-git-send-email-ayal@mellanox.com
Headers show
Series Add support for devlink health | expand

Message

Aya Levin Feb. 28, 2019, 12:12 p.m. UTC 
This series adds support for devlink health commands:
 devlink health show     [ DEV reporter REPORTER_NAME ]
 devlink health recover    DEV reporter REPORTER_NAME
 devlink health diagnose   DEV reporter REPORTER_NAME
 devlink health dump show  DEV reporter REPORTER_NAME
 devlink health dump clear DEV reporter REPORTER_NAME
 devlink health set        DEV reporter REPORTER_NAME { grace_period | auto_recover } { msec | boolean }

The first patch refactors the validation of input parameters, which
grow way too long. Second and third patches fix bugs that were
discovered during the devlink health development. The forth patch adds
helper functions which enable output of value and labels separately.
Patches 5-10 add the devlink health functionality by command, the last
is the man page.

Changelog:
v2:
-Add patch #4.
-Separate patch "Add support for devlink health" into patches (5-10)
by command.
-Patch #1 Changed function's name dl_args_finding_required_validate
and a small refactor.
-Modify show command's output.
v3:
-Add blank row that was wrongly added patch #4
-Rephrase commit message patch #5
-Some refactoring in patch #5
v4:
-Rebase: fix conflict with patch #5

Aya Levin (11):
  devlink: Refactor validation of finding required arguments
  devlink: Fix print of uint64_t
  devlink: Fix boolean JSON print
  devlink: Add helper functions for name and value separately
  devlink: Add devlink health show command
  devlink: Add devlink health recover command
  devlink: Add devlink health diagnose command
  devlink: Add devlink health dump show command
  devlink: Add devlink health dump clear command
  devlink: Add devlink health set command
  devlink: Add devlink-health man page

 devlink/devlink.c         | 725 ++++++++++++++++++++++++++++++++++++++--------
 man/man8/devlink-health.8 | 197 +++++++++++++
 man/man8/devlink.8        |   7 +-
 3 files changed, 815 insertions(+), 114 deletions(-)
 create mode 100644 man/man8/devlink-health.8

Comments

David Ahern Feb. 28, 2019, 4:01 p.m. UTC | #1 
On 2/28/19 5:12 AM, Aya Levin wrote:
> This series adds support for devlink health commands:
>  devlink health show     [ DEV reporter REPORTER_NAME ]
>  devlink health recover    DEV reporter REPORTER_NAME
>  devlink health diagnose   DEV reporter REPORTER_NAME
>  devlink health dump show  DEV reporter REPORTER_NAME
>  devlink health dump clear DEV reporter REPORTER_NAME
>  devlink health set        DEV reporter REPORTER_NAME { grace_period | auto_recover } { msec | boolean }
> 
> The first patch refactors the validation of input parameters, which
> grow way too long. Second and third patches fix bugs that were
> discovered during the devlink health development. The forth patch adds
> helper functions which enable output of value and labels separately.
> Patches 5-10 add the devlink health functionality by command, the last
> is the man page.
> 

applied to iproute2-next. Thanks