| Message ID | 1301525787-28447-1-git-send-email-philipp_subx@redfish-solutions.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Philip Prindeville <philipp_subx@redfish-solutions.com> Date: Wed, 30 Mar 2011 16:56:27 -0600 > From: Philip A. Prindeville <philipp@redfish-solutions.com> > > Use VPI.VCI notation consistently throughout the module. This is the > one remaining place where the VCI is used before the VPI in any output. > > Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> > --- > drivers/atm/solos-pci.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Why do your subject lines not have an appropriate prefix? How will someone scanning the commit header lines in the tree know that this is a change to the solos-pci driver unless you prefix them with "solos-pci: " or similar? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/30/11 5:03 PM, David Miller wrote: > From: Philip Prindeville <philipp_subx@redfish-solutions.com> > Date: Wed, 30 Mar 2011 16:56:27 -0600 > >> From: Philip A. Prindeville <philipp@redfish-solutions.com> >> >> Use VPI.VCI notation consistently throughout the module. This is the >> one remaining place where the VCI is used before the VPI in any output. >> >> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> >> --- >> drivers/atm/solos-pci.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > Why do your subject lines not have an appropriate prefix? > > How will someone scanning the commit header lines in the tree know > that this is a change to the solos-pci driver unless you prefix > them with "solos-pci: " or similar? It was an oversight. Want me to resubmit? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 25ef1a4..2c4146a 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -710,8 +710,8 @@ void solos_bh(unsigned long card_arg) le16_to_cpu(header->vci)); if (!vcc) { if (net_ratelimit()) - dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n", - le16_to_cpu(header->vci), le16_to_cpu(header->vpi), + dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n", + le16_to_cpu(header->vpi), le16_to_cpu(header->vci), port); continue; }