| Message ID | 1550668068-9661-1-git-send-email-fabrice.gasnier@st.com |
|---|---|
| Headers | show |
| Series | Add PM support to STM32 LP Timer drivers | expand |
On Wed, Feb 20, 2019 at 02:07:48PM +0100, Fabrice Gasnier wrote: > Add a device link between the PWM consumer and the PWM provider. This > enforces the PWM user to get suspended before the PWM provider. It > allows proper synchronization of suspend/resume sequences: the PWM user > is responsible for properly stopping PWM, before the provider gets > suspended: see [1]. Add the device link in: > - of_pwm_get() > - pwm_get() > - devm_*pwm_get() variants > as it requires a reference to the device for the PWM consumer. > > [1] https://lkml.org/lkml/2019/2/5/770 > > Suggested-by: Thierry Reding <thierry.reding@gmail.com> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On 2/20/19 2:07 PM, Fabrice Gasnier wrote: > This patch series adds power management support for STM32 LP Timer: > - PWM driver > - Document the pinctrl states for sleep mode > > It also adds device link between the PWM consumer and the PWM provider. > This allows proper sequencing for suspend/resume (e.g. user will likely > do a pwm_disable() before the PWM provider suspend executes), see [1]. > > [1] https://lkml.org/lkml/2019/2/5/770 Hi Thierry, Gentle reminder to review changes I've made in v5. Thanks in advance, Best Regards, Fabrice > > --- > Changes in v5: > - improve a warning message, fix a style issue. > > Changes in v4: > - improve error handling when adding the PWM consumer device link. > > Changes in v3: > - Move the device_link_add() call to of_pwm_get() as discussed with Uwe. > > Changes in v2: > - Don't disable PWM channel in PWM provider: rather refuse to suspend > and report an error as suggested by Uwe and Thierry. > - Add patch 3/3 to propose device link addition. > - No updates for STM32 LP Timer IIO driver. Patches can be send separately. > > Fabrice Gasnier (3): > dt-bindings: pwm-stm32-lp: document pinctrl sleep state > pwm: stm32-lp: Add power management support > pwm: core: add consumer device link > > .../devicetree/bindings/pwm/pwm-stm32-lp.txt | 9 ++-- > drivers/pwm/core.c | 50 ++++++++++++++++++++-- > drivers/pwm/pwm-stm32-lp.c | 25 +++++++++++ > include/linux/pwm.h | 6 ++- > 4 files changed, 82 insertions(+), 8 deletions(-) >