| Message ID | 20190220010232.18731-16-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | chardev: Convert qemu_chr_write() to take a size_t argument | expand |
On Wed, Feb 20, 2019 at 02:02:22AM +0100, Philippe Mathieu-Daudé wrote: > Both callers (h_put_term_char and rtas_display_character) use > an unsigned value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/char/spapr_vty.c | 2 +- > include/hw/ppc/spapr_vio.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c > index 6748334ded..92b8c40410 100644 > --- a/hw/char/spapr_vty.c > +++ b/hw/char/spapr_vty.c > @@ -83,7 +83,7 @@ static int vty_getchars(VIOsPAPRDevice *sdev, uint8_t *buf, int max) > return n; > } > > -void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, int len) > +void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, size_t len) > { > VIOsPAPRVTYDevice *dev = VIO_SPAPR_VTY_DEVICE(sdev); > > diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h > index e8b006d18f..ed79d2f380 100644 > --- a/include/hw/ppc/spapr_vio.h > +++ b/include/hw/ppc/spapr_vio.h > @@ -126,7 +126,7 @@ static inline int spapr_vio_dma_set(VIOsPAPRDevice *dev, uint64_t taddr, > int spapr_vio_send_crq(VIOsPAPRDevice *dev, uint8_t *crq); > > VIOsPAPRDevice *vty_lookup(sPAPRMachineState *spapr, target_ulong reg); > -void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, int len); > +void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, size_t len); > void spapr_vty_create(VIOsPAPRBus *bus, Chardev *chardev); > void spapr_vlan_create(VIOsPAPRBus *bus, NICInfo *nd); > void spapr_vscsi_create(VIOsPAPRBus *bus);
diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c index 6748334ded..92b8c40410 100644 --- a/hw/char/spapr_vty.c +++ b/hw/char/spapr_vty.c @@ -83,7 +83,7 @@ static int vty_getchars(VIOsPAPRDevice *sdev, uint8_t *buf, int max) return n; } -void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, int len) +void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, size_t len) { VIOsPAPRVTYDevice *dev = VIO_SPAPR_VTY_DEVICE(sdev); diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h index e8b006d18f..ed79d2f380 100644 --- a/include/hw/ppc/spapr_vio.h +++ b/include/hw/ppc/spapr_vio.h @@ -126,7 +126,7 @@ static inline int spapr_vio_dma_set(VIOsPAPRDevice *dev, uint64_t taddr, int spapr_vio_send_crq(VIOsPAPRDevice *dev, uint8_t *crq); VIOsPAPRDevice *vty_lookup(sPAPRMachineState *spapr, target_ulong reg); -void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, int len); +void vty_putchars(VIOsPAPRDevice *sdev, uint8_t *buf, size_t len); void spapr_vty_create(VIOsPAPRBus *bus, Chardev *chardev); void spapr_vlan_create(VIOsPAPRBus *bus, NICInfo *nd); void spapr_vscsi_create(VIOsPAPRBus *bus);
Both callers (h_put_term_char and rtas_display_character) use an unsigned value. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/char/spapr_vty.c | 2 +- include/hw/ppc/spapr_vio.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)