| Message ID | 20190205130346.77175-3-anup.patel@wdc.com |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | SiFive FU540 Support | expand |
Hi Anup, On Tue, 5 Feb 2019 at 06:04, Anup Patel <Anup.Patel@wdc.com> wrote: > > Currently, the mrproper make target tries to force remove all > "arch/*/include/asm/arch" paths assuming they are symlinks but > this prevents us from adding place-holder headers under the > arch/riscv/include/asm/arch directory. What is a placeholder header? Why do you need that? Regards, Simon > > To solve this, we fix mrproper make target to only remove > "arch/*/include/asm/arch" paths which are symlinks and do > nothing for paths which are directory. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index cf7b2b10bc..2d05b8da9a 100644 > --- a/Makefile > +++ b/Makefile > @@ -1782,7 +1782,7 @@ $(mrproper-dirs): > mrproper: clean $(mrproper-dirs) > $(call cmd,rmdirs) > $(call cmd,rmfiles) > - @rm -f arch/*/include/asm/arch > + @for d in `dirname arch/*/include/asm/arch`; do if [ -L $$d/arch ]; then echo " CLEAN "$$d/arch; rm -f $$d/arch; fi; done > > # distclean > # > -- > 2.17.1 >
On Tue, Feb 19, 2019 at 8:47 PM Simon Glass <sjg@chromium.org> wrote: > > Hi Anup, > > On Tue, 5 Feb 2019 at 06:04, Anup Patel <Anup.Patel@wdc.com> wrote: > > > > Currently, the mrproper make target tries to force remove all > > "arch/*/include/asm/arch" paths assuming they are symlinks but > > this prevents us from adding place-holder headers under the > > arch/riscv/include/asm/arch directory. > > What is a placeholder header? Why do you need that? This patch is dropped from v6 onwards. The placeholder header is asm/arch/clk.h which is required by drivers/net/macb.c Regards, Anup
diff --git a/Makefile b/Makefile index cf7b2b10bc..2d05b8da9a 100644 --- a/Makefile +++ b/Makefile @@ -1782,7 +1782,7 @@ $(mrproper-dirs): mrproper: clean $(mrproper-dirs) $(call cmd,rmdirs) $(call cmd,rmfiles) - @rm -f arch/*/include/asm/arch + @for d in `dirname arch/*/include/asm/arch`; do if [ -L $$d/arch ]; then echo " CLEAN "$$d/arch; rm -f $$d/arch; fi; done # distclean #
Currently, the mrproper make target tries to force remove all "arch/*/include/asm/arch" paths assuming they are symlinks but this prevents us from adding place-holder headers under the arch/riscv/include/asm/arch directory. To solve this, we fix mrproper make target to only remove "arch/*/include/asm/arch" paths which are symlinks and do nothing for paths which are directory. Signed-off-by: Anup Patel <anup.patel@wdc.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)