diff mbox series

[net-next,v2] bonding: check slave set command firstly

Message ID 1549910988-40999-1-git-send-email-xiangxia.m.yue@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next,v2] bonding: check slave set command firstly | expand

Commit Message

Tonghao Zhang Feb. 11, 2019, 6:49 p.m. UTC 
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

This patch is a little improvement. If user use the
command shown as below, we should print the info [1]
instead of [2]. The eth0 exists actually, and it may
confuse user.

$ echo "eth0" > /sys/class/net/bond4/bonding/slaves

[1] "bond4: no command found in slaves file - use +ifname or -ifname"
[2] "write error: No such device"

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
v2: fix compiling warning.
---
 drivers/net/bonding/bond_options.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Miller Feb. 14, 2019, 4:36 p.m. UTC | #1 
From: xiangxia.m.yue@gmail.com
Date: Mon, 11 Feb 2019 10:49:48 -0800

> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> This patch is a little improvement. If user use the
> command shown as below, we should print the info [1]
> instead of [2]. The eth0 exists actually, and it may
> confuse user.
> 
> $ echo "eth0" > /sys/class/net/bond4/bonding/slaves
> 
> [1] "bond4: no command found in slaves file - use +ifname or -ifname"
> [2] "write error: No such device"
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Applied, but would you please fix the dates on your submissions?

Because the dates in your patch postings are in the past, patchwork
puts your work at the tail of my patch queue instead of the front.

Thank you.
Tonghao Zhang Feb. 15, 2019, 1:44 a.m. UTC | #2 
On Fri, Feb 15, 2019 at 12:36 AM David Miller <davem@davemloft.net> wrote:
>
> From: xiangxia.m.yue@gmail.com
> Date: Mon, 11 Feb 2019 10:49:48 -0800
>
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > This patch is a little improvement. If user use the
> > command shown as below, we should print the info [1]
> > instead of [2]. The eth0 exists actually, and it may
> > confuse user.
> >
> > $ echo "eth0" > /sys/class/net/bond4/bonding/slaves
> >
> > [1] "bond4: no command found in slaves file - use +ifname or -ifname"
> > [2] "write error: No such device"
> >
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> Applied, but would you please fix the dates on your submissions?
>
> Because the dates in your patch postings are in the past, patchwork
> puts your work at the tail of my patch queue instead of the front.
OK, I format the patch a few days ago, but send it yesterday.
> Thank you.
David Miller Feb. 15, 2019, 1:53 a.m. UTC | #3 
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Fri, 15 Feb 2019 09:44:58 +0800

> OK, I format the patch a few days ago, but send it yesterday.

Just FYI, you can use various options to git such that it composes the
email using the current time rather than the date in the commit
itself.
diff mbox series

Patch

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 4d5d01c..da1fc17 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -1375,6 +1375,7 @@  static int bond_option_slaves_set(struct bonding *bond,
 	sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/
 	ifname = command + 1;
 	if ((strlen(command) <= 1) ||
+	    (command[0] != '+' && command[0] != '-') ||
 	    !dev_valid_name(ifname))
 		goto err_no_cmd;
 
@@ -1398,6 +1399,7 @@  static int bond_option_slaves_set(struct bonding *bond,
 		break;
 
 	default:
+		/* should not run here. */
 		goto err_no_cmd;
 	}