| Message ID | 20190125103824.9803-3-wens@csie.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | sunxi: Sync Bananapi M2+ dts files and add H5 variant | expand |
On Fri, Jan 25, 2019 at 4:09 PM Chen-Yu Tsai <wens@csie.org> wrote: > > The brand Sinovoip is used for Sinovoip's original VOIP products, while > the Bananapi brand is for the single board computers they produce. This > has been verified by Bananapi. Rename the board from "Sinovoip BPI M2 > Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is > used. > > To support the H5 variant of this board, the "H3" suffix is added to > the defconfig name. > > A symbolic link for the original defconfig, pointing to the new one, is > added to keep 3rd party distributions happy. Didn't find similar symbolic link with configs before, don't know if its fine to go with. Tom or anyone, Any comments on this?
On Wed, Feb 13, 2019 at 08:12:44PM +0530, Jagan Teki wrote: > On Fri, Jan 25, 2019 at 4:09 PM Chen-Yu Tsai <wens@csie.org> wrote: > > > > The brand Sinovoip is used for Sinovoip's original VOIP products, while > > the Bananapi brand is for the single board computers they produce. This > > has been verified by Bananapi. Rename the board from "Sinovoip BPI M2 > > Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is > > used. > > > > To support the H5 variant of this board, the "H3" suffix is added to > > the defconfig name. > > > > A symbolic link for the original defconfig, pointing to the new one, is > > added to keep 3rd party distributions happy. > > Didn't find similar symbolic link with configs before, don't know if > its fine to go with. > > Tom or anyone, > > Any comments on this? No symlinks please. Just update the docs as needed, thanks!
On Wed, Feb 13, 2019 at 11:33 PM Tom Rini <trini@konsulko.com> wrote: > > On Wed, Feb 13, 2019 at 08:12:44PM +0530, Jagan Teki wrote: > > On Fri, Jan 25, 2019 at 4:09 PM Chen-Yu Tsai <wens@csie.org> wrote: > > > > > > The brand Sinovoip is used for Sinovoip's original VOIP products, while > > > the Bananapi brand is for the single board computers they produce. This > > > has been verified by Bananapi. Rename the board from "Sinovoip BPI M2 > > > Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is > > > used. > > > > > > To support the H5 variant of this board, the "H3" suffix is added to > > > the defconfig name. > > > > > > A symbolic link for the original defconfig, pointing to the new one, is > > > added to keep 3rd party distributions happy. > > > > Didn't find similar symbolic link with configs before, don't know if > > its fine to go with. > > > > Tom or anyone, > > > > Any comments on this? > > No symlinks please. Just update the docs as needed, thanks! Got it. Will send v2 tomorrow. ChenYu
diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index 608a86be4970..f420c92e8c92 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -137,6 +137,13 @@ M: Jagan Teki <jagan@amarulasolutions.com> S: Maintained F: configs/bananapi_m2_berry_defconfig +BANANAPI M2 PLUS H3 BOARD +M: Icenowy Zheng <icenowy@aosc.io> +M: Chen-Yu Tsai <wens@csie.org> +S: Maintained +F: configs/bananapi_m2_plus_h3_defconfig +F: configs/Sinovoip_BPI_M2_Plus_defconfig + BANANAPI M2 ULTRA BOARD M: Chen-Yu Tsai <wens@csie.org> S: Maintained @@ -418,11 +425,6 @@ S: Maintained F: configs/Sinlinx_SinA33_defconfig W: http://linux-sunxi.org/Sinlinx_SinA33 -SINOVOIP BPI M2 PLUS H3 BOARD -M: Icenowy Zheng <icenowy@aosc.io> -S: Maintained -F: configs/Sinovoip_BPI_M2_Plus_defconfig - SINOVOIP BPI M3 A83T BOARD M: VishnuPatekar <vishnupatekar0510@gmail.com> S: Maintained diff --git a/configs/Sinovoip_BPI_M2_Plus_defconfig b/configs/Sinovoip_BPI_M2_Plus_defconfig deleted file mode 100644 index c2025ee0a499..000000000000 --- a/configs/Sinovoip_BPI_M2_Plus_defconfig +++ /dev/null @@ -1,20 +0,0 @@ -CONFIG_ARM=y -CONFIG_ARCH_SUNXI=y -CONFIG_SPL=y -CONFIG_MACH_SUN8I_H3=y -CONFIG_DRAM_CLK=672 -CONFIG_DRAM_ZQ=3881979 -CONFIG_DRAM_ODT_EN=y -CONFIG_MACPWR="PD6" -CONFIG_MMC_SUNXI_SLOT_EXTRA=2 -CONFIG_NR_DRAM_BANKS=1 -# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set -# CONFIG_CMD_FLASH is not set -# CONFIG_SPL_DOS_PARTITION is not set -# CONFIG_SPL_EFI_PARTITION is not set -CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-bananapi-m2-plus" -CONFIG_SUN8I_EMAC=y -CONFIG_USB_OHCI_HCD=y -CONFIG_USB_EHCI_HCD=y -CONFIG_USB_MUSB_GADGET=y -CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y diff --git a/configs/Sinovoip_BPI_M2_Plus_defconfig b/configs/Sinovoip_BPI_M2_Plus_defconfig new file mode 120000 index 000000000000..322e1e6d21f0 --- /dev/null +++ b/configs/Sinovoip_BPI_M2_Plus_defconfig @@ -0,0 +1 @@ +bananapi_m2_plus_h3_defconfig \ No newline at end of file
The brand Sinovoip is used for Sinovoip's original VOIP products, while the Bananapi brand is for the single board computers they produce. This has been verified by Bananapi. Rename the board from "Sinovoip BPI M2 Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is used. To support the H5 variant of this board, the "H3" suffix is added to the defconfig name. A symbolic link for the original defconfig, pointing to the new one, is added to keep 3rd party distributions happy. Also add myself as one of the board maintainers. As the device tree files were already correctly named, they do not require any changes. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- board/sunxi/MAINTAINERS | 12 ++++++----- configs/Sinovoip_BPI_M2_Plus_defconfig | 21 +------------------ ...efconfig => bananapi_m2_plus_h3_defconfig} | 0 3 files changed, 8 insertions(+), 25 deletions(-) mode change 100644 => 120000 configs/Sinovoip_BPI_M2_Plus_defconfig copy configs/{Sinovoip_BPI_M2_Plus_defconfig => bananapi_m2_plus_h3_defconfig} (100%) diff --git a/configs/Sinovoip_BPI_M2_Plus_defconfig b/configs/bananapi_m2_plus_h3_defconfig similarity index 100% copy from configs/Sinovoip_BPI_M2_Plus_defconfig copy to configs/bananapi_m2_plus_h3_defconfig