| Message ID | 20190202230224.10331-6-lukma@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS | expand |
Hi Lukasz On Sun, 2019-02-03 at 00:02 +0100, Lukasz Majewski wrote: > As the I2C2 clock is now enabled in the generic clock code, we can > remove > this code from a board file. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > Changes in v3: > - New patch (separate board code patch) > > Changes in v2: None > > board/phytec/pcm052/pcm052.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/phytec/pcm052/pcm052.c > b/board/phytec/pcm052/pcm052.c > index f988af2abc..cfc8009102 100644 > --- a/board/phytec/pcm052/pcm052.c > +++ b/board/phytec/pcm052/pcm052.c > @@ -485,7 +485,7 @@ static void clock_init(void) > clrsetbits_le32(&ccm->ccgr9, CCM_REG_CTRL_MASK, > CCM_CCGR9_FEC0_CTRL_MASK | > CCM_CCGR9_FEC1_CTRL_MASK); > clrsetbits_le32(&ccm->ccgr10, CCM_REG_CTRL_MASK, > - CCM_CCGR10_NFC_CTRL_MASK | > CCM_CCGR10_I2C2_CTRL_MASK); > + CCM_CCGR10_NFC_CTRL_MASK); > > clrsetbits_le32(&anadig->pll2_ctrl, ANADIG_PLL2_CTRL_POWERDOWN, > ANADIG_PLL2_CTRL_ENABLE | > ANADIG_PLL2_CTRL_DIV_SELECT); I can confirm that a similar change also works on Colibri VF50/VF61 albeit there on I2C0 rather than I2C2. Cheers Marcel
diff --git a/board/phytec/pcm052/pcm052.c b/board/phytec/pcm052/pcm052.c index f988af2abc..cfc8009102 100644 --- a/board/phytec/pcm052/pcm052.c +++ b/board/phytec/pcm052/pcm052.c @@ -485,7 +485,7 @@ static void clock_init(void) clrsetbits_le32(&ccm->ccgr9, CCM_REG_CTRL_MASK, CCM_CCGR9_FEC0_CTRL_MASK | CCM_CCGR9_FEC1_CTRL_MASK); clrsetbits_le32(&ccm->ccgr10, CCM_REG_CTRL_MASK, - CCM_CCGR10_NFC_CTRL_MASK | CCM_CCGR10_I2C2_CTRL_MASK); + CCM_CCGR10_NFC_CTRL_MASK); clrsetbits_le32(&anadig->pll2_ctrl, ANADIG_PLL2_CTRL_POWERDOWN, ANADIG_PLL2_CTRL_ENABLE | ANADIG_PLL2_CTRL_DIV_SELECT);
As the I2C2 clock is now enabled in the generic clock code, we can remove this code from a board file. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- Changes in v3: - New patch (separate board code patch) Changes in v2: None board/phytec/pcm052/pcm052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)