| Message ID | 20190209063052.29092-6-anup.patel@wdc.com |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | SiFive FU540 Support | expand |
On Sat, 2019-02-09 at 06:31 +0000, Anup Patel wrote: > Some of the drivers expect asm/arch/clk.h to be provided by > arch support code so we add place-holder asm/arch/clk.h for > RISC-V support. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 arch/riscv/include/asm/arch/clk.h > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
On Sat, Feb 9, 2019 at 2:31 PM Anup Patel <Anup.Patel@wdc.com> wrote: > > Some of the drivers expect asm/arch/clk.h to be provided by > arch support code so we add place-holder asm/arch/clk.h for > RISC-V support. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 arch/riscv/include/asm/arch/clk.h I looked at this and understand why patch [1/16] and [2/16] are needed. But can we do the same like other architectures, ie: creating directory include/asm/arch-xxx instead? Creating a hard-coded include/asm/arch directory prevents us from expanding SoC/platform specific support in the future. > > diff --git a/arch/riscv/include/asm/arch/clk.h b/arch/riscv/include/asm/arch/clk.h > new file mode 100644 > index 0000000000..1631f5f0bd > --- /dev/null > +++ b/arch/riscv/include/asm/arch/clk.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + * > + * Authors: > + * Anup Patel <anup.patel@wdc.com> > + */ > + > +#ifndef __ASM_RISCV_ARCH_CLK_H > +#define __ASM_RISCV_ARCH_CLK_H > + > +/* Note: This is a placeholder header for driver compilation. */ > + > +#endif > -- Regards, Bin
> -----Original Message----- > From: Bin Meng [mailto:bmeng.cn@gmail.com] > Sent: Monday, February 11, 2019 8:51 AM > To: Anup Patel <Anup.Patel@wdc.com> > Cc: Rick Chen <rick@andestech.com>; Joe Hershberger > <joe.hershberger@ni.com>; Michal Simek <monstr@monstr.eu>; Michal > Simek <michal.simek@xilinx.com>; Lukas Auer > <lukas.auer@aisec.fraunhofer.de>; Masahiro Yamada > <yamada.masahiro@socionext.com>; Simon Glass <sjg@chromium.org>; > Alexander Graf <agraf@suse.de>; Palmer Dabbelt <palmer@sifive.com>; > Paul Walmsley <paul.walmsley@sifive.com>; Atish Patra > <Atish.Patra@wdc.com>; U-Boot Mailing List <u-boot@lists.denx.de>; Tom > Rini <trini@konsulko.com> > Subject: Re: [PATCH v6 05/16] riscv: Add place-holder asm/arch/clk.h for > driver compilation > > On Sat, Feb 9, 2019 at 2:31 PM Anup Patel <Anup.Patel@wdc.com> wrote: > > > > Some of the drivers expect asm/arch/clk.h to be provided by arch > > support code so we add place-holder asm/arch/clk.h for RISC-V support. > > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > --- > > arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 arch/riscv/include/asm/arch/clk.h > > I looked at this and understand why patch [1/16] and [2/16] are needed. But > can we do the same like other architectures, ie: creating directory > include/asm/arch-xxx instead? Creating a hard-coded include/asm/arch > directory prevents us from expanding SoC/platform specific support in the > future. Even Tom suggested similar thing. I will use CREATE_ARCH_SYMLINK instead in next version of patchset. Regards, Anup
diff --git a/arch/riscv/include/asm/arch/clk.h b/arch/riscv/include/asm/arch/clk.h new file mode 100644 index 0000000000..1631f5f0bd --- /dev/null +++ b/arch/riscv/include/asm/arch/clk.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * + * Authors: + * Anup Patel <anup.patel@wdc.com> + */ + +#ifndef __ASM_RISCV_ARCH_CLK_H +#define __ASM_RISCV_ARCH_CLK_H + +/* Note: This is a placeholder header for driver compilation. */ + +#endif
Some of the drivers expect asm/arch/clk.h to be provided by arch support code so we add place-holder asm/arch/clk.h for RISC-V support. Signed-off-by: Anup Patel <anup.patel@wdc.com> --- arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 arch/riscv/include/asm/arch/clk.h