Message ID | CACRpkdYRiWZbkduBRxQdPC_1hJjQJCYhX9NFB31t1Su1CSBNyw@mail.gmail.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] SPEAr defconfig update | expand |
On Mon, Jan 21, 2019 at 1:30 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > Hi ARM SoC maintainers, > > this: > 1. updates the SPEAr 3xx defconfig > 2. replaces the fbdev PL11x framebuffer driver with the DRM PL11x driver > in the defconfig > > This has the ACK of the SPEAr maintainer Viresh Kumar. I don't think > there even is a SPEAr git tree so I send this from my GPIO tree. If they > have other plans, they can say so now :D > > Please pull it into ARM SoC in the appropriate place, next kernel is I have a similar comment to the nomadik update, though there is only one non-obvious option: why do you turn on CONFIG_PREEMPT=y? Arnd
On Wed, Jan 30, 2019 at 10:52 PM Arnd Bergmann <arnd@arndb.de> wrote: > On Mon, Jan 21, 2019 at 1:30 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > Hi ARM SoC maintainers, > > > > this: > > 1. updates the SPEAr 3xx defconfig > > 2. replaces the fbdev PL11x framebuffer driver with the DRM PL11x driver > > in the defconfig > > > > This has the ACK of the SPEAr maintainer Viresh Kumar. I don't think > > there even is a SPEAr git tree so I send this from my GPIO tree. If they > > have other plans, they can say so now :D > > > > Please pull it into ARM SoC in the appropriate place, next kernel is > > I have a similar comment to the nomadik update, though there > is only one non-obvious option: why do you turn on CONFIG_PREEMPT=y? Oh that's just something from my script, sorry. It'd good that it comes up but I guess it should be a separate patch. These are not servers so any other configuration than CONFIG_PREEMPT is probably just wrong, as is any other setting than Tickless idle and HRTimers on. I am thinking maybe we should actually have ARMv7 and ARMv8 multi Kconfig simply select these things, I don't really see why anyone would want to configure these differently, it just seems vaguely cargoculty and overcautious. Yours, Linus Walleij
On Thu, Jan 31, 2019 at 9:03 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jan 30, 2019 at 10:52 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Mon, Jan 21, 2019 at 1:30 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > > Hi ARM SoC maintainers, > > > > > > this: > > > 1. updates the SPEAr 3xx defconfig > > > 2. replaces the fbdev PL11x framebuffer driver with the DRM PL11x driver > > > in the defconfig > > > > > > This has the ACK of the SPEAr maintainer Viresh Kumar. I don't think > > > there even is a SPEAr git tree so I send this from my GPIO tree. If they > > > have other plans, they can say so now :D > > > > > > Please pull it into ARM SoC in the appropriate place, next kernel is > > > > I have a similar comment to the nomadik update, though there > > is only one non-obvious option: why do you turn on CONFIG_PREEMPT=y? > > Oh that's just something from my script, sorry. > > It'd good that it comes up but I guess it should be a > separate patch. > > These are not servers so any other configuration than > CONFIG_PREEMPT is probably just wrong, as is any > other setting than Tickless idle and HRTimers on. > > I am thinking maybe we should actually have ARMv7 and > ARMv8 multi Kconfig simply select these things, I don't > really see why anyone would want to configure these > differently, it just seems vaguely cargoculty and overcautious. Yes, I agree that turning these on is a good idea, but please send that as a separate patch. One patch to turn it on in all configurations you care about is fine. Arnd