diff mbox series

package/upmpdcli: fix static build issue

Message ID 20190124100717.12620-1-joerg.krause@embedded.rocks
State Accepted
Headers show
Series package/upmpdcli: fix static build issue | expand

Commit Message

Jörg Krause Jan. 24, 2019, 10:07 a.m. UTC
The spotify plugin requires shared library support and needs <dlfcn.h>.
Explicitly disable the spotify plugin when building upmpdcli in a static
context.

Fixes:
http://autobuild.buildroot.net/results/cb942d3c5f68959d6cbc85535ccff4a275369f91/

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 package/upmpdcli/upmpdcli.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Jan. 27, 2019, 8:46 p.m. UTC | #1
On Thu, 24 Jan 2019 11:07:17 +0100
Jörg Krause <joerg.krause@embedded.rocks> wrote:

> The spotify plugin requires shared library support and needs <dlfcn.h>.
> Explicitly disable the spotify plugin when building upmpdcli in a static
> context.
> 
> Fixes:
> http://autobuild.buildroot.net/results/cb942d3c5f68959d6cbc85535ccff4a275369f91/
> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
>  package/upmpdcli/upmpdcli.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
index d88caac78b..22a5bf2429 100644
--- a/package/upmpdcli/upmpdcli.mk
+++ b/package/upmpdcli/upmpdcli.mk
@@ -10,6 +10,11 @@  UPMPDCLI_LICENSE = LGPL-2.1+
 UPMPDCLI_LICENSE_FILES = COPYING
 UPMPDCLI_DEPENDENCIES = host-pkgconf libmpdclient libupnpp libmicrohttpd jsoncpp
 
+# Disable spotify plugin which requires dlfcn.h
+ifeq ($(BR2_STATIC_LIBS),y)
+UPMPDCLI_CONF_OPTS = --disable-spotify
+endif
+
 # Upmpdcli only runs if user upmpdcli exists
 define UPMPDCLI_USERS
 	upmpdcli -1 upmpdcli -1 * - - audio Upmpdcli MPD UPnP Renderer Front-End