| Message ID | 20190117185628.21862-3-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Tests: target architecture support | expand |
On Thu, Jan 17, 2019 at 01:56:12PM -0500, Cleber Rosa wrote: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test alone that takes on average ~5 seconds > to run, we intend to adapt the list of tests to match the user's build > environment (among other choices). > > Because of that, let's present the default Avocado UI by default. > Users can always choose a different output by setting the AVOCADO_SHOW > variable. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Caio Carrara <ccarrara@redhat.com> > --- > .travis.yml | 2 +- > tests/Makefile.include | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 93fd0164a0..844d514afa 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -188,7 +188,7 @@ matrix: > # Acceptance (Functional) tests > - env: > - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" > - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance" > + - TEST_CMD="make check-acceptance" > addons: > apt: > packages: > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f403a6571d..c73298740d 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > # Controls the output generated by Avocado when running tests. > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > -AVOCADO_SHOW=none > +AVOCADO_SHOW=app > > PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)') > ifeq ($(PYTHON3), 1) > -- > 2.20.1 >
On 1/17/19 7:56 PM, Cleber Rosa wrote: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test alone that takes on average ~5 seconds > to run, we intend to adapt the list of tests to match the user's build > environment (among other choices). > > Because of that, let's present the default Avocado UI by default. > Users can always choose a different output by setting the AVOCADO_SHOW > variable. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > .travis.yml | 2 +- > tests/Makefile.include | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 93fd0164a0..844d514afa 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -188,7 +188,7 @@ matrix: > # Acceptance (Functional) tests > - env: > - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" > - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance" > + - TEST_CMD="make check-acceptance" > addons: > apt: > packages: > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f403a6571d..c73298740d 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > # Controls the output generated by Avocado when running tests. > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > -AVOCADO_SHOW=none > +AVOCADO_SHOW=app > > PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)') > ifeq ($(PYTHON3), 1) >
Cleber Rosa <crosa@redhat.com> writes: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test alone that takes on average ~5 seconds > to run, we intend to adapt the list of tests to match the user's build > environment (among other choices). > > Because of that, let's present the default Avocado UI by default. > Users can always choose a different output by setting the AVOCADO_SHOW > variable. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > tests/Makefile.include | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 93fd0164a0..844d514afa 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -188,7 +188,7 @@ matrix: > # Acceptance (Functional) tests > - env: > - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" > - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance" > + - TEST_CMD="make check-acceptance" > addons: > apt: > packages: > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f403a6571d..c73298740d 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > # Controls the output generated by Avocado when running tests. > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > -AVOCADO_SHOW=none > +AVOCADO_SHOW=app > > PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)') > ifeq ($(PYTHON3), 1) -- Alex Bennée
diff --git a/.travis.yml b/.travis.yml index 93fd0164a0..844d514afa 100644 --- a/.travis.yml +++ b/.travis.yml @@ -188,7 +188,7 @@ matrix: # Acceptance (Functional) tests - env: - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance" + - TEST_CMD="make check-acceptance" addons: apt: packages: diff --git a/tests/Makefile.include b/tests/Makefile.include index f403a6571d..c73298740d 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results # Controls the output generated by Avocado when running tests. # Any number of command separated loggers are accepted. For more # information please refer to "avocado --help". -AVOCADO_SHOW=none +AVOCADO_SHOW=app PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)') ifeq ($(PYTHON3), 1)
The current version of the "check-acceptance" target will only show one line for execution of all tests. That's probably OK if the tests to be run are quick enough and they're always the same. But, there's already one test alone that takes on average ~5 seconds to run, we intend to adapt the list of tests to match the user's build environment (among other choices). Because of that, let's present the default Avocado UI by default. Users can always choose a different output by setting the AVOCADO_SHOW variable. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- .travis.yml | 2 +- tests/Makefile.include | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)