| Message ID | 20190118194812.3319-1-martyn.welch@collabora.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor | expand |
Hi Martyn, On Fri, Jan 18, 2019 at 5:49 PM Martyn Welch <martyn.welch@collabora.com> wrote: > + /* > + * Set the minimum memory size here and > + * let the bootloader set the real size. > + */ > + memory { Need to pass device_type = "memory"; > + reg = <0x80000000 0x8000000>; > + }; > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; Uneeded line. > + > + pinctrl_enet1: enet1grp { > +&iomuxc { > + pinctrl_gpio_keys: gpio_keysgrp { > + fsl,pins = < > + MX6UL_PAD_SNVS_TAMPER0__GPIO5_IO00 0x79 > + >; > + }; > + > + pinctrl_user_leds: user_ledsgrp { > + fsl,pins = < > + MX6UL_PAD_JTAG_MOD__GPIO1_IO10 0x79 > + MX6UL_PAD_GPIO1_IO01__GPIO1_IO01 0x79 > + >; > + }; > +}; > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > new file mode 100644 > index 000000000000..83cdf4fa10c0 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH > + * Author: Christian Hemp <c.hemp@phytec.de> > + */ > + > +/dts-v1/; > +#include "imx6ul-phytec-pcl063.dtsi" > +#include "imx6ul-phytec-phyboard-segin.dtsi" > +#include "imx6ul-phytec-peb-eval-01.dtsi" > + > +/ { > + model = "Phytec phyBOARD-Segin i.MX6 UltraLite Full Featured"; > + compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063", > + "fsl,imx6ul"; Better keep it in a single line? > +&ecspi3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi3>; > + cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + > + spidev@0 { > + compatible = "spidev"; Doesn't the kernel complain about spidev dts nodes? > +}; > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi > new file mode 100644 > index 000000000000..bccabb84c9f6 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi > @@ -0,0 +1,330 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH > + * Author: Christian Hemp <c.hemp@phytec.de> > + */ > + > +/ { > + model = "Phytec phyBOARD-Segin i.MX6 UltraLite"; > + compatible = "phytec,imx6ul-pbacd-10", "phytec,imx6ul-pcl063", > + "fsl,imx6ul"; Single line? > +&i2c1 { > + codec: tlv320@18 { Node names should be generic and label names specific, so: tlv320: codec@18 > + compatible = "ti,tlv320aic3007"; > + #sound-dai-cells = <0>; > + reg = <0x18>; > + AVDD-supply = <®_sound_3v3>; > + IOVDD-supply = <®_sound_3v3>; > + DRVDD-supply = <®_sound_3v3>; > + DVDD-supply = <®_sound_1v8>; > + status = "disabled"; > + }; > + > + stmpe: stmpe@44 { touchscreen@44
Hi Martyn, Am 18.01.19 um 20:48 schrieb Martyn Welch: > Add vendor prefix "catalyst" for Catalyst Semiconductor which is > already in use but undocumented. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > > Changes in v2: None > > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 389508584f48..d80b23b7771f 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -65,6 +65,7 @@ bticino Bticino International > calxeda Calxeda > capella Capella Microsystems, Inc > cascoda Cascoda, Ltd. > +catalyst Catalyst Semiconductor, Inc "Inc" surely is an abbreviation for "Incorporated", so can you please follow the below examples of writing "Inc." with trailing dot? > cavium Cavium, Inc. > cdns Cadence Design Systems Inc. > cdtech CDTech(H.K.) Electronics Limited Otherwise looks good. Thanks for fixing the undocumented use. Regards, Andreas
Hi Fabio, On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote: > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin- > > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > new file mode 100644 > > index 000000000000..83cdf4fa10c0 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > @@ -0,0 +1,96 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH > > + * Author: Christian Hemp <c.hemp@phytec.de> > > + */ > > + > > +/dts-v1/; > > +#include "imx6ul-phytec-pcl063.dtsi" > > +#include "imx6ul-phytec-phyboard-segin.dtsi" > > +#include "imx6ul-phytec-peb-eval-01.dtsi" > > + > > +/ { > > + model = "Phytec phyBOARD-Segin i.MX6 UltraLite Full > > Featured"; > > + compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul- > > pcl063", > > + "fsl,imx6ul"; > > Better keep it in a single line? > It makes it longer than 80 chars, but I'm not adverse to that. > > +&ecspi3 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ecspi3>; > > + cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > + > > + spidev@0 { > > + compatible = "spidev"; > > Doesn't the kernel complain about spidev dts nodes? > Oh, yes, it does when spidev is loaded... Removing. Martyn
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 389508584f48..d80b23b7771f 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -65,6 +65,7 @@ bticino Bticino International calxeda Calxeda capella Capella Microsystems, Inc cascoda Cascoda, Ltd. +catalyst Catalyst Semiconductor, Inc cavium Cavium, Inc. cdns Cadence Design Systems Inc. cdtech CDTech(H.K.) Electronics Limited