mbox series

[0/2] can: flexcan: add PE clock source select support

Message ID 20181213070537.25095-1-qiangqing.zhang@nxp.com
Headers show
Series can: flexcan: add PE clock source select support | expand

Message

Joakim Zhang Dec. 13, 2018, 7:07 a.m. UTC 
The patch set intends to add support for PE clock source select. The
FlexCAN controller can parse "fsl,clk-source" property from device tree
to select clock source.

Dong Aisheng (2):
  Documentation: can: flexcan: add PE clock source property to device
    tree
  can: flexcan: add support for PE clock source select

 .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
 drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
 2 files changed, 22 insertions(+), 4 deletions(-)

Comments

Joakim Zhang Jan. 17, 2019, 6:27 a.m. UTC | #1 
Kindly Ping...

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Joakim Zhang
> Sent: 2018年12月13日 15:08
> To: mkl@pengutronix.de; robh@kernel.org
> Cc: linux-can@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; Joakim
> Zhang <qiangqing.zhang@nxp.com>
> Subject: [PATCH 0/2] can: flexcan: add PE clock source select support
> 
> The patch set intends to add support for PE clock source select. The FlexCAN
> controller can parse "fsl,clk-source" property from device tree to select clock
> source.
> 
> Dong Aisheng (2):
>   Documentation: can: flexcan: add PE clock source property to device
>     tree
>   can: flexcan: add support for PE clock source select
> 
>  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
>  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
>  2 files changed, 22 insertions(+), 4 deletions(-)
> 
> --
> 2.17.1
Joakim Zhang Feb. 14, 2019, 9:57 a.m. UTC | #2 
Kindly Ping...

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Joakim Zhang
> Sent: 2019年1月17日 14:28
> To: mkl@pengutronix.de; robh@kernel.org
> Cc: linux-can@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: RE: [PATCH 0/2] can: flexcan: add PE clock source select support
> 
> 
> Kindly Ping...
> 
> Best Regards,
> Joakim Zhang
> 
> > -----Original Message-----
> > From: Joakim Zhang
> > Sent: 2018年12月13日 15:08
> > To: mkl@pengutronix.de; robh@kernel.org
> > Cc: linux-can@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; Joakim
> > Zhang <qiangqing.zhang@nxp.com>
> > Subject: [PATCH 0/2] can: flexcan: add PE clock source select support
> >
> > The patch set intends to add support for PE clock source select. The
> > FlexCAN controller can parse "fsl,clk-source" property from device
> > tree to select clock source.
> >
> > Dong Aisheng (2):
> >   Documentation: can: flexcan: add PE clock source property to device
> >     tree
> >   can: flexcan: add support for PE clock source select
> >
> >  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
> >  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
> >  2 files changed, 22 insertions(+), 4 deletions(-)
> >
> > --
> > 2.17.1
Marc Kleine-Budde Feb. 27, 2019, 8:46 a.m. UTC | #3 
On 12/13/18 8:07 AM, Joakim Zhang wrote:
> The patch set intends to add support for PE clock source select. The
> FlexCAN controller can parse "fsl,clk-source" property from device tree
> to select clock source.
> 
> Dong Aisheng (2):
>   Documentation: can: flexcan: add PE clock source property to device
>     tree
>   can: flexcan: add support for PE clock source select
> 
>  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
>  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
>  2 files changed, 22 insertions(+), 4 deletions(-)

Added to linux-can-next.

Tnx,
Marc
Marc Kleine-Budde Feb. 27, 2019, 11 a.m. UTC | #4 
On 2/27/19 9:46 AM, Marc Kleine-Budde wrote:
> On 12/13/18 8:07 AM, Joakim Zhang wrote:
>> The patch set intends to add support for PE clock source select. The
>> FlexCAN controller can parse "fsl,clk-source" property from device tree
>> to select clock source.
>>
>> Dong Aisheng (2):
>>   Documentation: can: flexcan: add PE clock source property to device
>>     tree
>>   can: flexcan: add support for PE clock source select
>>
>>  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
>>  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
>>  2 files changed, 22 insertions(+), 4 deletions(-)
> 
> Added to linux-can-next.

With one change:

> @@ -1369,7 +1371,10 @@ static int register_flexcandev(struct net_device *dev)
>                 goto out_clks_disable;
> 
>         reg = priv->read(&regs->ctrl);
> -       reg |= FLEXCAN_CTRL_CLK_SRC;
> +       if (priv->clk_src)
> +               reg |= FLEXCAN_CTRL_CLK_SRC;
> +       else
> +               reg &= ~FLEXCAN_CTRL_CLK_SRC;

...the FLEXCAN_CTRL_CLK_SRC bit is cleared now.

Marc