| Message ID | 20190115163522.31918-1-ap420073@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: bpfilter: change section name of bpfilter UMH blob. | expand |
From: Taehee Yoo <ap420073@gmail.com> Date: Wed, 16 Jan 2019 01:35:22 +0900 > The section of bpfilter UMH blob is the ".bpfilter_umh". but this is not > an explicit section. so linking warning occurred at compile time for the > powerpc. > So, this patch makes use of the ".rodata" instead of the ".bpfilter_umh". > > Config condition: > > CONFIG_BPFILTER=y > CONFIG_BPFILTER_UMH=y > > Result: > > ld: warning: orphan section `.bpfilter_umh' from > `net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh' > > Fixes: 61fbf5933d42 ("net: bpfilter: restart bpfilter_umh when error occurred") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Taehee Yoo <ap420073@gmail.com> Applied.
diff --git a/net/bpfilter/bpfilter_umh_blob.S b/net/bpfilter/bpfilter_umh_blob.S index 7f1c521dcc2f..9ea6100dca87 100644 --- a/net/bpfilter/bpfilter_umh_blob.S +++ b/net/bpfilter/bpfilter_umh_blob.S @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ - .section .bpfilter_umh, "a" + .section .rodata, "a" .global bpfilter_umh_start bpfilter_umh_start: .incbin "net/bpfilter/bpfilter_umh"
The section of bpfilter UMH blob is the ".bpfilter_umh". but this is not an explicit section. so linking warning occurred at compile time for the powerpc. So, this patch makes use of the ".rodata" instead of the ".bpfilter_umh". Config condition: CONFIG_BPFILTER=y CONFIG_BPFILTER_UMH=y Result: ld: warning: orphan section `.bpfilter_umh' from `net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh' Fixes: 61fbf5933d42 ("net: bpfilter: restart bpfilter_umh when error occurred") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- net/bpfilter/bpfilter_umh_blob.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)