mbox series

[0/3] soc: fsl: add DPAA2 log console support

Message ID 1545406240-3061-1-git-send-email-ioana.ciornei@nxp.com
Headers show
Series soc: fsl: add DPAA2 log console support | expand

Message

Ioana Ciornei Dec. 21, 2018, 3:31 p.m. UTC 
This patch set adds support for exporting DPAA2 firmware console
logs to userspace.

The first two patches add the needed device tree node and its documentation
while the third one adds the actual platform driver.

Ioana Ciornei (3):
  arm64: dts: add dpaa2-console node for DPAA2 platforms
  Documentation: DT: Add entry for DPAA2 console
  soc: fsl: add DPAA2 console support

 .../devicetree/bindings/misc/dpaa2-console.txt     |  11 +
 MAINTAINERS                                        |   1 +
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi     |   5 +
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi     |   5 +
 drivers/soc/fsl/Kconfig                            |  10 +
 drivers/soc/fsl/Makefile                           |   1 +
 drivers/soc/fsl/dpaa2-console.c                    | 306 +++++++++++++++++++++
 7 files changed, 339 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/dpaa2-console.txt
 create mode 100644 drivers/soc/fsl/dpaa2-console.c

Comments

Shawn Guo Jan. 12, 2019, 2:47 a.m. UTC | #1 
On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> Add the dpaa2-console device tree node for the following
> DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

DTS patch generally goes to the last in a series.

Shawn
Ioana Ciornei Jan. 16, 2019, 10:02 a.m. UTC | #2 
> Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> platforms
> 
> On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> > Add the dpaa2-console device tree node for the following
> > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> 
> DTS patch generally goes to the last in a series.

Should I resend this with the DTS patch the last?

Ioana

> 
> Shawn
Shawn Guo Jan. 16, 2019, 10:56 a.m. UTC | #3 
On Wed, Jan 16, 2019 at 10:02:01AM +0000, Ioana Ciornei wrote:
> > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > platforms
> > 
> > On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> > > Add the dpaa2-console device tree node for the following
> > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > >
> > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > 
> > DTS patch generally goes to the last in a series.
> 
> Should I resend this with the DTS patch the last?

You do not have to resend the series only for this.  It's pretty much a
suggestion for future posting.

Shawn
Ioana Ciornei Jan. 16, 2019, 10:59 a.m. UTC | #4 
> Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> platforms
> 
> On Wed, Jan 16, 2019 at 10:02:01AM +0000, Ioana Ciornei wrote:
> > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > DPAA2 platforms
> > >
> > > On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> > > > Add the dpaa2-console device tree node for the following
> > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > >
> > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > >
> > > DTS patch generally goes to the last in a series.
> >
> > Should I resend this with the DTS patch the last?
> 
> You do not have to resend the series only for this.  It's pretty much a suggestion
> for future posting.

Ok, thanks for the suggestion.

Ioana
Ioana Ciornei Jan. 16, 2019, 5:31 p.m. UTC | #5 
> > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > platforms
> >
> > On Wed, Jan 16, 2019 at 10:02:01AM +0000, Ioana Ciornei wrote:
> > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > > DPAA2 platforms
> > > >
> > > > On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> > > > > Add the dpaa2-console device tree node for the following
> > > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > > >
> > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > > >
> > > > DTS patch generally goes to the last in a series.
> > >
> > > Should I resend this with the DTS patch the last?
> >
> > You do not have to resend the series only for this.  It's pretty much
> > a suggestion for future posting.
> 

One more thing, do you have any other feedback on the DTS part?
I think the best path for this patch set is through Leo's fsl soc tree but of course we need an ack from the DTS part also.

Thanks,
Ioana
Shawn Guo Jan. 22, 2019, 2:53 a.m. UTC | #6 
On Wed, Jan 16, 2019 at 05:31:46PM +0000, Ioana Ciornei wrote:
> > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2
> > > platforms
> > >
> > > On Wed, Jan 16, 2019 at 10:02:01AM +0000, Ioana Ciornei wrote:
> > > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for
> > > > > DPAA2 platforms
> > > > >
> > > > > On Fri, Dec 21, 2018 at 03:31:09PM +0000, Ioana Ciornei wrote:
> > > > > > Add the dpaa2-console device tree node for the following
> > > > > > DPAA2 based platforms: LS1088A, LS2080A and LS2088A.
> > > > > >
> > > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > > > >
> > > > > DTS patch generally goes to the last in a series.
> > > >
> > > > Should I resend this with the DTS patch the last?
> > >
> > > You do not have to resend the series only for this.  It's pretty much
> > > a suggestion for future posting.
> > 
> 
> One more thing, do you have any other feedback on the DTS part?
> I think the best path for this patch set is through Leo's fsl soc tree but of course we need an ack from the DTS part also.

I do not see there is a hard dependency between driver and dts part,
e.g. build error or causing regression.  In that case, dts should just
go via its channel.

Shawn