| Message ID | ada22a208bf433f96c4974a3d3aafc389272f3c9.1539378302.git.joseph.salisbury@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | nvme: Use admin command effects for admin commands | expand |
On 08/01/2019 19:57, Joseph Salisbury wrote: > From: Keith Busch <keith.busch@intel.com> > > BugLink: https://bugs.launchpad.net/bugs/1797587 > The patch is missing the following text from the commit message: "nvme: Use admin command effects for admin commands" > Signed-off-by: Keith Busch <keith.busch@intel.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331) > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index c5dfca8..42f6202 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > } > > if (ctrl->effects) > - effects = le32_to_cpu(ctrl->effects->iocs[opcode]); > + effects = le32_to_cpu(ctrl->effects->acs[opcode]); > else > effects = nvme_known_admin_effects(opcode); > >
On 1/8/19 8:57 PM, Joseph Salisbury wrote: > From: Keith Busch <keith.busch@intel.com> > > BugLink: https://bugs.launchpad.net/bugs/1797587 > > Signed-off-by: Keith Busch <keith.busch@intel.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331) > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> The commit doesn't really have a message apart from the s-o-b's, the missing line pointed out by Colin is actually the subject line, so the patch looks fine: Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index c5dfca8..42f6202 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > } > > if (ctrl->effects) > - effects = le32_to_cpu(ctrl->effects->iocs[opcode]); > + effects = le32_to_cpu(ctrl->effects->acs[opcode]); > else > effects = nvme_known_admin_effects(opcode); >
On 08.01.19 20:57, Joseph Salisbury wrote: > From: Keith Busch <keith.busch@intel.com> > > BugLink: https://bugs.launchpad.net/bugs/1797587 > > Signed-off-by: Keith Busch <keith.busch@intel.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331) > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- As Kleber already pouinted out there is nothing but the subject and s-o-b in the original patch. Does not make it much nicer to read but meh. > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index c5dfca8..42f6202 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > } > > if (ctrl->effects) > - effects = le32_to_cpu(ctrl->effects->iocs[opcode]); > + effects = le32_to_cpu(ctrl->effects->acs[opcode]); > else > effects = nvme_known_admin_effects(opcode); > >
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index c5dfca8..42f6202 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, } if (ctrl->effects) - effects = le32_to_cpu(ctrl->effects->iocs[opcode]); + effects = le32_to_cpu(ctrl->effects->acs[opcode]); else effects = nvme_known_admin_effects(opcode);