| Message ID | 1545555435-24576-21-git-send-email-Julia.Lawall@lip6.fr |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | drop useless LIST_HEAD | expand |
Julia Lawall <Julia.Lawall@lip6.fr> writes: > Drop LIST_HEAD where the variable it declares has never > been used. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // </smpl> > > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > Successfully 0-day tested on 151 configurations. I assume I can take this to wireless-drivers-next. If you are planning to push this via some other tree please let me know.
On Tue, 8 Jan 2019, Kalle Valo wrote: > Julia Lawall <Julia.Lawall@lip6.fr> writes: > > > Drop LIST_HEAD where the variable it declares has never > > been used. > > > > The semantic patch that fixes this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @@ > > identifier x; > > @@ > > - LIST_HEAD(x); > > ... when != x > > // </smpl> > > > > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > --- > > Successfully 0-day tested on 151 configurations. > > I assume I can take this to wireless-drivers-next. If you are planning > to push this via some other tree please let me know. Please take it. Thanks. julia
Julia Lawall <Julia.Lawall@lip6.fr> wrote: > Drop LIST_HEAD where the variable it declares has never > been used. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // </smpl> > > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Patch applied to wireless-drivers-next.git, thanks. 06605b0d38b4 cw1200: drop useless LIST_HEAD
diff --git a/drivers/net/wireless/st/cw1200/queue.c b/drivers/net/wireless/st/cw1200/queue.c index 7c31b63b8258..7895efefa95d 100644 --- a/drivers/net/wireless/st/cw1200/queue.c +++ b/drivers/net/wireless/st/cw1200/queue.c @@ -283,7 +283,6 @@ int cw1200_queue_put(struct cw1200_queue *queue, struct cw1200_txpriv *txpriv) { int ret = 0; - LIST_HEAD(gc_list); struct cw1200_queue_stats *stats = queue->stats; if (txpriv->link_id >= queue->stats->map_capacity)
Drop LIST_HEAD where the variable it declares has never been used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; @@ - LIST_HEAD(x); ... when != x // </smpl> Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- Successfully 0-day tested on 151 configurations. drivers/net/wireless/st/cw1200/queue.c | 1 - 1 file changed, 1 deletion(-)