Message ID | 20181211013743.31663-1-blp@ovn.org |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] tests: Include actual Address Sanitizer output in testsuite log. | expand |
Acked-by: Mark Michelson <mmichels@redhat.com> On 12/10/18 8:37 PM, Ben Pfaff wrote: > This will make it easier to get the Address Sanitizer output in cases > where we only have the testsuite.log, which happens with some autobuilders. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > tests/ovs-macros.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at > index f2e6114ae822..fe7f0aa90f20 100644 > --- a/tests/ovs-macros.at > +++ b/tests/ovs-macros.at > @@ -190,6 +190,7 @@ OVS_START_SHELL_HELPERS > ovs_cleanup() { > if test "$(echo asan.*)" != 'asan.*'; then > echo "Address Sanitizer reported errors in:" asan.* > + cat asan.* > AT_FAIL_IF([:]) > fi > } >
Thanks, applied to master. On Thu, Dec 13, 2018 at 03:25:47PM -0500, Mark Michelson wrote: > Acked-by: Mark Michelson <mmichels@redhat.com> > > On 12/10/18 8:37 PM, Ben Pfaff wrote: > >This will make it easier to get the Address Sanitizer output in cases > >where we only have the testsuite.log, which happens with some autobuilders. > > > >Signed-off-by: Ben Pfaff <blp@ovn.org> > >--- > > tests/ovs-macros.at | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at > >index f2e6114ae822..fe7f0aa90f20 100644 > >--- a/tests/ovs-macros.at > >+++ b/tests/ovs-macros.at > >@@ -190,6 +190,7 @@ OVS_START_SHELL_HELPERS > > ovs_cleanup() { > > if test "$(echo asan.*)" != 'asan.*'; then > > echo "Address Sanitizer reported errors in:" asan.* > >+ cat asan.* > > AT_FAIL_IF([:]) > > fi > > } > > >
diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at index f2e6114ae822..fe7f0aa90f20 100644 --- a/tests/ovs-macros.at +++ b/tests/ovs-macros.at @@ -190,6 +190,7 @@ OVS_START_SHELL_HELPERS ovs_cleanup() { if test "$(echo asan.*)" != 'asan.*'; then echo "Address Sanitizer reported errors in:" asan.* + cat asan.* AT_FAIL_IF([:]) fi }
This will make it easier to get the Address Sanitizer output in cases where we only have the testsuite.log, which happens with some autobuilders. Signed-off-by: Ben Pfaff <blp@ovn.org> --- tests/ovs-macros.at | 1 + 1 file changed, 1 insertion(+)