| Message ID | 20181219233519.35287-1-khilman@baylibre.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi, Sorry for the repeat : I replied previously to v1 as I hadn't noticed that there was already a v2. Le 20/12/2018 à 00:35, Kevin Hilman a écrit : > Add new vendor for amediatech, and initial board: x96-max > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> > --- > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt > index 8dbc259081e4..c50b084b6c59 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.txt > +++ b/Documentation/devicetree/bindings/arm/amlogic.txt > @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): > - "amlogic,p281" (Meson gxl s905w) > - "oranth,tx3-mini" (Meson gxl s905w) > > + - "amediatech,x96-max" (Meson gxm s912) Shouldn't that be Meson g12a s905x2 ? Cheers, Chris
Chris Moore <moore@free.fr> writes: > Hi, > > Sorry for the repeat : I replied previously to v1 as I hadn't noticed > that there was already a v2. > > Le 20/12/2018 à 00:35, Kevin Hilman a écrit : >> Add new vendor for amediatech, and initial board: x96-max >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- >> Documentation/devicetree/bindings/arm/amlogic.txt | 1 + >> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt >> index 8dbc259081e4..c50b084b6c59 100644 >> --- a/Documentation/devicetree/bindings/arm/amlogic.txt >> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt >> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): >> - "amlogic,p281" (Meson gxl s905w) >> - "oranth,tx3-mini" (Meson gxl s905w) >> >> + - "amediatech,x96-max" (Meson gxm s912) > > Shouldn't that be Meson g12a s905x2 ? Ugh, yes. Lazy copy/paste bug. Will fix that in a v3 next year. :) Thanks for the review, Kevin
Hi Kevin, On Thu, Dec 20, 2018 at 12:35 AM Kevin Hilman <khilman@baylibre.com> wrote: > > Add new vendor for amediatech, and initial board: x96-max as we have seen there is no "amediatech" branding anywhere on the board itself however, FCC gave us a clue about the manufacturer: [0] can you please add this info to the patch description when re-sending? > Signed-off-by: Kevin Hilman <khilman@baylibre.com> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> (with the two comments below) > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + if Rob is fine with vendor-prefixes.txt being updated together with adding a new board then I'm as well :) > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt > index 8dbc259081e4..c50b084b6c59 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.txt > +++ b/Documentation/devicetree/bindings/arm/amlogic.txt > @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): > - "amlogic,p281" (Meson gxl s905w) > - "oranth,tx3-mini" (Meson gxl s905w) > > + - "amediatech,x96-max" (Meson gxm s912) I assume that you'll not only fix the SoC here (G12A) as reported by Chris Moore but also the ordering Regards Martin [0] https://fccid.io/2AI6D-X96MAX
Hi Kevin, On 20/12/2018 00:35, Kevin Hilman wrote: > Add the G12a (S905X2) based X96 Max board[1]. > > There is no branding for the manufacturer anywhere on the product, so it > took some digging to find the manufacturer. But since there's nothing > about the maker on the product I've left it out of the DT name because > 1) nobody will know that name and 2) keeps the DT filename shorter. > > [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/ > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> > --- > .../boot/dts/amlogic/meson-g12a-x96-max.dts | 28 +++++++++++++++++++ Just found out you forgot to update the Makefile !! Neil [snip] > + > +&uart_AO { > + status = "okay"; > +}; >
Chris Moore <moore@free.fr> writes: > Hi, > > Sorry for the repeat : I replied previously to v1 as I hadn't noticed > that there was already a v2. > > Le 20/12/2018 à 00:35, Kevin Hilman a écrit : >> Add new vendor for amediatech, and initial board: x96-max >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- >> Documentation/devicetree/bindings/arm/amlogic.txt | 1 + >> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt >> index 8dbc259081e4..c50b084b6c59 100644 >> --- a/Documentation/devicetree/bindings/arm/amlogic.txt >> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt >> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): >> - "amlogic,p281" (Meson gxl s905w) >> - "oranth,tx3-mini" (Meson gxl s905w) >> >> + - "amediatech,x96-max" (Meson gxm s912) > > Shouldn't that be Meson g12a s905x2 ? Yes indeed. Kevin
Neil Armstrong <narmstrong@baylibre.com> writes: > Hi Kevin, > > On 20/12/2018 00:35, Kevin Hilman wrote: >> Add the G12a (S905X2) based X96 Max board[1]. >> >> There is no branding for the manufacturer anywhere on the product, so it >> took some digging to find the manufacturer. But since there's nothing >> about the maker on the product I've left it out of the DT name because >> 1) nobody will know that name and 2) keeps the DT filename shorter. >> >> [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/ >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- >> .../boot/dts/amlogic/meson-g12a-x96-max.dts | 28 +++++++++++++++++++ > > Just found out you forgot to update the Makefile !! D'oh, fixing for v3. Kevin
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > Hi Kevin, > > On Thu, Dec 20, 2018 at 12:35 AM Kevin Hilman <khilman@baylibre.com> wrote: >> >> Add new vendor for amediatech, and initial board: x96-max > as we have seen there is no "amediatech" branding anywhere on the board itself > however, FCC gave us a clue about the manufacturer: [0] > can you please add this info to the patch description when re-sending? Yes, will add. >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > (with the two comments below) > >> Documentation/devicetree/bindings/arm/amlogic.txt | 1 + >> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > if Rob is fine with vendor-prefixes.txt being updated together with > adding a new board then I'm as well :) > >> 2 files changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt >> index 8dbc259081e4..c50b084b6c59 100644 >> --- a/Documentation/devicetree/bindings/arm/amlogic.txt >> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt >> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): >> - "amlogic,p281" (Meson gxl s905w) >> - "oranth,tx3-mini" (Meson gxl s905w) >> >> + - "amediatech,x96-max" (Meson gxm s912) > I assume that you'll not only fix the SoC here (G12A) as reported by > Chris Moore but also the ordering Yes, will fix. Kevin
diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt index 8dbc259081e4..c50b084b6c59 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.txt +++ b/Documentation/devicetree/bindings/arm/amlogic.txt @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC): - "amlogic,p281" (Meson gxl s905w) - "oranth,tx3-mini" (Meson gxl s905w) + - "amediatech,x96-max" (Meson gxm s912) - "amlogic,q200" (Meson gxm s912) - "amlogic,q201" (Meson gxm s912) - "khadas,vim2" (Meson gxm s912) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8c413d8cc2a5..c1bb0c220429 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -24,6 +24,7 @@ amarula Amarula Solutions amazon Amazon.com, Inc. amcc Applied Micro Circuits Corporation (APM, formally AMCC) amd Advanced Micro Devices (AMD), Inc. +amediatech Shenzhen Amediatech Technology Co., Ltd amlogic Amlogic, Inc. ampire Ampire Co., Ltd. ams AMS AG
Add new vendor for amediatech, and initial board: x96-max Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- Documentation/devicetree/bindings/arm/amlogic.txt | 1 + Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 2 insertions(+)